public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Update test case to comply with GCC14 changes
@ 2024-02-10 15:21 Torbjörn SVENSSON
  2024-02-11 19:01 ` Mike Stump
  0 siblings, 1 reply; 3+ messages in thread
From: Torbjörn SVENSSON @ 2024-02-10 15:21 UTC (permalink / raw)
  To: gcc-patches; +Cc: mikestump, rearnsha, Torbjörn SVENSSON

I have confirmed that this updated pr97969.c file still hangs with
gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969.

Ok for trunk?

--

The test case for PR97969 needs updates in order to comply with recent
changes in GCC14.  Without these changes, failures like this can be seen
on arm-none-eabi:

.../pr97969.c:6:9: error: type defaults to 'int' in declaration of 'a' [-Wimplicit-int]
.../pr97969.c:34:1: error: return type defaults to 'int' [-Wimplicit-int]
.../pr97969.c:40:3: error: implicit declaration of function 'ae' [-Wimplicit-function-declaration]
.../pr97969.c:42:3: error: implicit declaration of function 'af' [-Wimplicit-function-declaration]
.../pr97969.c:43:7: error: implicit declaration of function 'ag' [-Wimplicit-function-declaration]
.../pr97969.c:46:10: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
.../pr97969.c:48:10: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
.../pr97969.c:50:8: error: implicit declaration of function 'setjmp' [-Wimplicit-function-declaration]
.../pr97969.c:51:5: error: implicit declaration of function 'ah' [-Wimplicit-function-declaration]
.../pr97969.c:52:5: error: implicit declaration of function 'ai' [-Wimplicit-function-declaration]
.../pr97969.c:54:5: error: implicit declaration of function 'aj' [-Wimplicit-function-declaration]

Patch has been verified on Linux.

gcc/testsuite/ChangeLog:

	* gcc.target/arm/pr97969.c: Update to comply with GCC14 changes.

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
 gcc/testsuite/gcc.target/arm/pr97969.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/gcc/testsuite/gcc.target/arm/pr97969.c b/gcc/testsuite/gcc.target/arm/pr97969.c
index b8c3a23676a..af69e47ad9f 100644
--- a/gcc/testsuite/gcc.target/arm/pr97969.c
+++ b/gcc/testsuite/gcc.target/arm/pr97969.c
@@ -3,17 +3,17 @@
 /* { dg-options "-std=c99 -fno-omit-frame-pointer -w -Os" } */
 /* { dg-add-options arm_arch_v6m } */
 
-typedef a[23];
+typedef int a[23];
 enum { b };
 typedef struct {
   int c;
   char *e;
-  char f
+  char f;
 } d;
 typedef enum { g = 1 } h;
 typedef struct {
   h i;
-  int j
+  int j;
 } k;
 typedef struct {
   a l;
@@ -29,9 +29,18 @@ typedef struct {
   d t;
   d *u;
   short v;
-  int w
+  int w;
 } aa;
-c(char x, int y, char z, int ab) {
+
+void ae(short*, int, int);
+void af(aa*, int, char, int);
+int ag(int);
+void ah(aa);
+void ai(int);
+void aj(aa);
+int setjmp();
+
+int c(char x, int y, char z, int ab) {
   aa ac;
   ac.r.i = 0;
   d ad;
@@ -43,9 +52,9 @@ c(char x, int y, char z, int ab) {
   if (ag(0))
     return 0;
   if (x)
-    ac.s = z + ab;
+    ac.s = (char*)(z + ab);
   else
-    ac.s = x + y;
+    ac.s = (char*)(x + y);
   ac.o |= g;
   if (!setjmp()) {
     ah(ac);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite: Update test case to comply with GCC14 changes
  2024-02-10 15:21 [PATCH] testsuite: Update test case to comply with GCC14 changes Torbjörn SVENSSON
@ 2024-02-11 19:01 ` Mike Stump
  2024-02-11 19:56   ` Torbjorn SVENSSON
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Stump @ 2024-02-11 19:01 UTC (permalink / raw)
  To: Torbjörn SVENSSON; +Cc: gcc-patches, rearnsha

On Feb 10, 2024, at 7:21 AM, Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> wrote:
> 
> I have confirmed that this updated pr97969.c file still hangs with
> gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969.
> 
> Ok for trunk?

Ok.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] testsuite: Update test case to comply with GCC14 changes
  2024-02-11 19:01 ` Mike Stump
@ 2024-02-11 19:56   ` Torbjorn SVENSSON
  0 siblings, 0 replies; 3+ messages in thread
From: Torbjorn SVENSSON @ 2024-02-11 19:56 UTC (permalink / raw)
  To: Mike Stump; +Cc: gcc-patches, rearnsha



On 2024-02-11 20:01, Mike Stump wrote:
> On Feb 10, 2024, at 7:21 AM, Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> wrote:
>>
>> I have confirmed that this updated pr97969.c file still hangs with
>> gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969.
>>
>> Ok for trunk?
> 
> Ok.

Pushed as f85450819414700a7883a7de128b03f655f43d44.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-11 19:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-10 15:21 [PATCH] testsuite: Update test case to comply with GCC14 changes Torbjörn SVENSSON
2024-02-11 19:01 ` Mike Stump
2024-02-11 19:56   ` Torbjorn SVENSSON

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).