public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Georg-Johann Lay <avr@gjlay.de>
To: Jonathan Wakely <jwakely@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][wwwdocs] Improve grammar for AVR changes in GCC 14
Date: Mon, 22 Apr 2024 13:35:29 +0200	[thread overview]
Message-ID: <7e983ffa-33db-428d-82f5-86409613091a@gjlay.de> (raw)
In-Reply-To: <20240422100454.1607124-1-jwakely@redhat.com>

Am 22.04.24 um 12:04 schrieb Jonathan Wakely:
> OK for wwwdocs?

For me it's ok (I am not a native speaker though,
which is the reason the typos are there to begin with).

Johann

>   htdocs/gcc-14/changes.html | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index 9509487c..21d33db8 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -696,13 +696,13 @@ a work-in-progress.</p>
>   <h3 id="avr">AVR</h3>
>   <ul>
>     <li>On AVR64* and AVR128* devices, read-only data is now located in program
> -    memory per default and no more in RAM.
> +    memory per default and no longer in RAM.
>       <ul>
>         <li>Only a 32&nbsp;KiB block of program memory can be used to store
>   	and access .rodata in that way. Which block is used can be selected
> -	by defining symbol <code>__flmap</code>.
> +	by defining the symbol <code>__flmap</code>.
>   	As an alternative, the byte address of the block can be specified
> -	by symbol <code>__RODATA_FLASH_START__</code> which takes
> +	by the symbol <code>__RODATA_FLASH_START__</code> which takes
>   	precedence over <code>__flmap</code>.
>   	For example, linking with
>   	<code>-Wl,--defsym,__RODATA_FLASH_START__=32k</code>
> @@ -715,9 +715,9 @@ a work-in-progress.</p>
>   	href="https://github.com/avrdudes/avr-libc/issues/931">#931</a>
>   	can be used. The latter initializes <code>NVMCTRL_CTRLB.FLMAP</code>
>   	in the startup code and according to the value
> -	of&nbsp;<code>__flmap</code> resp.
> +	of&nbsp;<code>__flmap</code> or
>   	<code>__RODATA_FLASH_START__</code>.</li>
> -      <li>When AVR-LibC with&nbsp;#931 is used, then defining symbol
> +      <li>When AVR-LibC with&nbsp;#931 is used, then defining the symbol
>   	<code>__flmap_lock</code> to a non-zero value will set bit
>   	<code>NVMCTRL_CTRLB.FLMAPLOCK</code>. This will protect
>   	<code>NVMCTRL_CTRLB.FLMAP</code> from any further changes &mdash;
> @@ -726,7 +726,7 @@ a work-in-progress.</p>
>   	can be used:<pre>
>   __asm (".global __flmap_lock"  "\n\t"
>          "__flmap_lock = 1");</pre></li>
> -      <li>When you do not want the code from&nbsp;#931, then define global
> +      <li>When you do not want the code from&nbsp;#931, then define a global
>   	symbol <code>__do_flmap_init</code> and the linker will not pull in
>   	that code from <code>lib<var>mcu</var>.a</code> any more.</li>
>         <li>In order to return to the old placement of read-only data in RAM,
> @@ -736,7 +736,7 @@ __asm (".global __flmap_lock"  "\n\t"
>   	  functionality.</b>
>         </li>
>         <li>Read-only data is located in output section <code>.rodata</code>,
> -	wheras it is part of <code>.text</code> when located in RAM.</li>
> +	whereas it is part of <code>.text</code> when located in RAM.</li>
>         <li>The feature is only available when the compiler is configured
>   	with a version of Binutils that implements
>   	<a href="https://sourceware.org/PR31124">PR31124</a>, which is the
> @@ -784,7 +784,7 @@ __asm (".global __flmap_lock"  "\n\t"
>     <li>
>       On the Reduced Tiny devices,
>       the meaning of register constraint&nbsp;<code>"w"</code> has been changed.
> -    It containts now the registers R24&hellip;R31 like it is the case for all
> +    It now constrains the registers R24&hellip;R31 as is the case for all
>       the other devices.
>     </li>
>   </ul>

  reply	other threads:[~2024-04-22 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 10:04 Jonathan Wakely
2024-04-22 11:35 ` Georg-Johann Lay [this message]
2024-05-01 13:37   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e983ffa-33db-428d-82f5-86409613091a@gjlay.de \
    --to=avr@gjlay.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).