OpenMP – patches pending review

OpenMP – patches pending review

[Tobias Burnus]

Outstanding but submitted patches:

* [Patch] OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE [PR86470]
(March 10, 2021)
https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566529.html

* [Patch] OpenMP: Fix combined-target handling for lastprivate/reduction/linear [PR99928]
(April 9, 2021)
https://gcc.gnu.org/pipermail/gcc-patches/2021-April/567838.html


For completeness:

* [Patch] OpenMP: Support complex/float in && and || reduction
(last Friday)
https://gcc.gnu.org/pipermail/gcc-patches/2021-April/569362.html

[to-do by me, i.e. pending some post-review fixes by me and then re-submission:
  * [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause
  https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568820.html ]

Thanks,

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf

Re: OpenMP patches pending review

[Jakub Jelinek]

On Wed, May 25, 2022 at 09:25:19AM +0200, Tobias Burnus wrote:
> first – thanks for all the reviews – both quick and though.
> 
> Pending review are:
> 
> * Julian's struct/declare mapper patch set:
> 10/11 – OpenMP: Use OMP_ARRAY_SECTION instead of TREE_LIST for array sections in C FE
> 11/11 - OpenMP: Support OpenMP 5.0 "declare mapper" directives for C

Generally, the same things apply to these C FE patches as to the C++ FE
patches (except that the C++ patches usually included also generic code
changes while the C FE patches didn't).

	Jakub

OpenMP patches pending review

[Tobias Burnus]

Hi all, hi Jakub,

first – thanks for all the reviews – both quick and though.

Pending review are:

* Julian's struct/declare mapper patch set:
10/11 – OpenMP: Use OMP_ARRAY_SECTION instead of TREE_LIST for array sections in C FE
11/11 - OpenMP: Support OpenMP 5.0 "declare mapper" directives for C

All others (00/11 to 09/11) have been reviewed yesterday. (Thanks!)

(Whether 10/11 and 11/11 should be better reviewed before or after re-submission
of the revised patches, I don' know.)


* Kwok's metadirectives patches (0/7 .. 7/7) at:
"[PATCH 0/7] openmp: OpenMP metadirectives support   Kwok Cheung Yeung"
https://gcc.gnu.org/pipermail/gcc-patches/2021-December/thread.html#586600

With some follow-up fixes:
(1) "[PATCH] openmp: Metadirective patch fixes"
     https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589190.html
(2) [PATCH] openmp: Add support for target_device selector set in metadirectives
     https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589191.html
+ follow up fix to plugin-nvptx in the same thread:
     https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589269.html
(3) [PATCH] openmp: Add warning when functions containing metadirectives with 'construct={target}' called directly
     https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589427.html
(4) Follow-up fix to (6/7) patch for Fortran:
     [PATCH 6/7] openmp, fortran: Add Fortran support for parsing metadirectives
     https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590349.html
(5) [PATCH] openmp: Improve handling of nested OpenMP metadirectives in C and C++ (was: Re: [PATCH 1/7] openmp: Add C support for parsing metadirectives)
     https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590592.html


* A bunch of additional patches are pending, which either small but depend on other patches
    or are larger – but I intent to ping them separately. For some overview, see the old thread at
       https://gcc.gnu.org/pipermail/gcc/2022-May/238642.html
in particular: memory management + unified-shared-memory and the kernels management
and depending on others: omp_get_max_teams, omp_set_num_teams, and omp_{gs}et_teams_thread_limit
+ Fortran deep mapping (working but should be better handled chopped in pieces)


Reviewed and now requires to be revised:

* 01/11 to 09/11 of the struct rework/declare mapper patches as remarked above
* by-device environment variables
* Probably some additional patches

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955