public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Patrick O'Neill <patrick@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: fortran@gcc.gnu.org, Jeff Law <jeffreyalaw@gmail.com>,
	gnu-toolchain <gnu-toolchain@rivosinc.com>
Subject: [PING] [PATCH] gfortran: Rely on dg-do-what-default to avoid running pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets
Date: Wed, 15 Nov 2023 16:03:12 -0800	[thread overview]
Message-ID: <83365982-71b9-46ae-8253-457841caaf99@rivosinc.com> (raw)
In-Reply-To: <20231102190911.66763-1-patrick@rivosinc.com>

Ping.

Testsuite fixup similar to:
https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com/T/#t
https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a103429e@rivosinc.com/T/#t

Patrick

On Thu, Nov 2, 2023 at 12:09 PM Patrick O'Neill <patrick@rivosinc.com> 
wrote:
>
> Testcases in gfortran.dg/vect/vect.exp rely on
> check_vect_support_and_set_flags to set dg-do-what-default and avoid
> running vector tests on non-vector targets. The three testcases in this
> patch overwrite the default with dg-do run which causes issues
> for non-vector targets.
>
> Removing the dg-do run directive resolves this issue for non-vector
> targets (while still running the tests on vector targets).
>
> gcc/testsuite/ChangeLog:
>
>         * gfortran.dg/vect/pr107254.f90: Remove dg-do run directive.
>         * gfortran.dg/vect/pr85853.f90: Ditto.
>         * gfortran.dg/vect/vect-alias-check-1.F90: Ditto.
>
> Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
> ---
> Tested using rv64gc & rv64gcv to make sure the testcases compile/run
> as expected.
>
> These files haven't been changed in a long time so I'm not sure why (or
> if) this hasn't been run into by other people before.
> ---
>  gcc/testsuite/gfortran.dg/vect/pr107254.f90           | 2 --
>  gcc/testsuite/gfortran.dg/vect/pr85853.f90            | 1 -
>  gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 | 1 -
>  3 files changed, 4 deletions(-)
>
> diff --git a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 b/gcc/testsuite/gfortran.dg/vect/pr107254.f90
> index 85bcb5f3fa2..adce6bedc30 100644
> --- a/gcc/testsuite/gfortran.dg/vect/pr107254.f90
> +++ b/gcc/testsuite/gfortran.dg/vect/pr107254.f90
> @@ -1,5 +1,3 @@
> -! { dg-do run }
> -
>  subroutine dlartg( f, g, s, r )
>    implicit none
>    double precision :: f, g, r, s
> diff --git a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 b/gcc/testsuite/gfortran.dg/vect/pr85853.f90
> index 68f4a004324..4c0e3b81a09 100644
> --- a/gcc/testsuite/gfortran.dg/vect/pr85853.f90
> +++ b/gcc/testsuite/gfortran.dg/vect/pr85853.f90
> @@ -1,5 +1,4 @@
>  ! Taken from execute/where_2.f90, but with special flags.
> -! { dg-do run }
>  ! { dg-additional-options "-fno-tree-loop-vectorize" }
>
>  ! Program to test the WHERE constructs
> diff --git a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90
> index 3014ff9f3b6..85ae9b151e3 100644
> --- a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90
> +++ b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90
> @@ -1,4 +1,3 @@
> -! { dg-do run }
>  ! { dg-additional-options "-fno-inline" }
>
>  #define N 200
> --
> 2.34.1
>

  reply	other threads:[~2023-11-16  0:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 19:09 Patrick O'Neill
2023-11-16  0:03 ` Patrick O'Neill [this message]
2023-11-19  4:09   ` [PING] " Jeff Law
2023-11-21 18:03     ` [Committed] " Patrick O'Neill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83365982-71b9-46ae-8253-457841caaf99@rivosinc.com \
    --to=patrick@rivosinc.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    --cc=jeffreyalaw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).