[PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets

[PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets

[Patrick O'Neill]

Testcases in g++.dg/vect rely on check_vect_support_and_set_flags
to set dg-do-what-default and avoid running vector tests on non-vector
targets. The three testcases in this patch overwrite the default with
dg-do run.

Removing the dg-do run directive resolves this issue for non-vector
targets (while still running the tests on vector targets).

gcc/testsuite/ChangeLog:

	* g++.dg/vect/pr102788.cc: Remove dg-do run directive.

Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
---
Tested using rv64gc & rv64gcv to make sure the testcases compile/run
as expected.

Similar to https://inbox.sourceware.org/gcc-patches/20231102190911.66763-1-patrick@rivosinc.com/T/#u
---
 gcc/testsuite/g++.dg/vect/pr102788.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gcc/testsuite/g++.dg/vect/pr102788.cc b/gcc/testsuite/g++.dg/vect/pr102788.cc
index fa9c366fe56..032fa29fc72 100644
--- a/gcc/testsuite/g++.dg/vect/pr102788.cc
+++ b/gcc/testsuite/g++.dg/vect/pr102788.cc
@@ -1,4 +1,3 @@
-// { dg-do run }
 // { dg-additional-options "-O3" }

 unsigned long long int var_4 = 235;
--
2.34.1

Re: [PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets

[Jeff Law]

On 11/2/23 17:45, Patrick O'Neill wrote:
> Testcases in g++.dg/vect rely on check_vect_support_and_set_flags
> to set dg-do-what-default and avoid running vector tests on non-vector
> targets. The three testcases in this patch overwrite the default with
> dg-do run.
> 
> Removing the dg-do run directive resolves this issue for non-vector
> targets (while still running the tests on vector targets).
> 
> gcc/testsuite/ChangeLog:
> 
> 	* g++.dg/vect/pr102788.cc: Remove dg-do run directive.
OK.  I'll note your patch has just one file patched, but your comment 
indicates three testcases have this problem.  Did you forget to include 
a couple changes?

If so, those are pre-approved as well.  Just post them for the archiver 
and commit.

Thanks,
jeff

[Committed] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets

[Patrick O'Neill]

On 11/9/23 17:20, Jeff Law wrote:
>
>
> On 11/2/23 17:45, Patrick O'Neill wrote:
>> Testcases in g++.dg/vect rely on check_vect_support_and_set_flags
>> to set dg-do-what-default and avoid running vector tests on non-vector
>> targets. The three testcases in this patch overwrite the default with
>> dg-do run.
>>
>> Removing the dg-do run directive resolves this issue for non-vector
>> targets (while still running the tests on vector targets).
>>
>> gcc/testsuite/ChangeLog:
>>
>>     * g++.dg/vect/pr102788.cc: Remove dg-do run directive.
> OK.  I'll note your patch has just one file patched, but your comment 
> indicates three testcases have this problem.  Did you forget to 
> include a couple changes?
>
> If so, those are pre-approved as well.  Just post them for the 
> archiver and commit.
>
> Thanks,
> jeff
Committed

The comment was mistakenly copy/pasted from 
https://inbox.sourceware.org/gcc-patches/20231102190911.66763-1-patrick@rivosinc.com/T/#u
Revised commit message to only mention the one testcase.

Thanks,
Patrick