public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] configure: Do not build the unused libffi shared library.
@ 2022-12-31 14:16 Iain Sandoe
  2022-12-31 17:23 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Iain Sandoe @ 2022-12-31 14:16 UTC (permalink / raw)
  To: gcc-patches

Tested on i686/powerpc/x86_64/aarch64 Darwin, x86_64-linux-gnu,
OK for master?
thanks
Iain

--- 8< ---

We do not use the shared libffi library, nor do we install it.
However, on at least Darwin, the shared version will be picked
up for testing, so it is preferrable not to build it.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

ChangeLog:

	* Makefile.def: Do not build shared libffi.
	* Makefile.in: Regenerate.
---
 Makefile.def | 3 ++-
 Makefile.in  | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile.def b/Makefile.def
index 86d15f1982f..35e994eb77e 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -181,7 +181,8 @@ target_modules = { module= libtermcap; no_check=true;
                    missing=maintainer-clean; };
 target_modules = { module= winsup; };
 target_modules = { module= libgloss; no_check=true; };
-target_modules = { module= libffi; no_install=true; };
+target_modules = { module= libffi; no_install=true;
+                   extra_configure_flags='--disable-shared --with-pic'; };
 target_modules = { module= zlib; bootstrap=true; };
 target_modules = { module= rda; };
 target_modules = { module= libada; };
diff --git a/Makefile.in b/Makefile.in
index d66e6208fa2..06a9398e172 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -55467,7 +55467,7 @@ configure-target-libffi:
 	  $$s/$$module_srcdir/configure \
 	  --srcdir=$${topdir}/$$module_srcdir \
 	  $(TARGET_CONFIGARGS) --build=${build_alias} --host=${target_alias} \
-	  --target=${target_alias}  \
+	  --target=${target_alias} --disable-shared --with-pic \
 	  || exit 1
 @endif target-libffi
 
-- 
2.37.1 (Apple Git-137.1)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure: Do not build the unused libffi shared library.
  2022-12-31 14:16 [PATCH] configure: Do not build the unused libffi shared library Iain Sandoe
@ 2022-12-31 17:23 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-12-31 17:23 UTC (permalink / raw)
  To: iain; +Cc: gcc-patches, Iain Sandoe



> Am 31.12.2022 um 15:16 schrieb Iain Sandoe via Gcc-patches <gcc-patches@gcc.gnu.org>:
> 
> Tested on i686/powerpc/x86_64/aarch64 Darwin, x86_64-linux-gnu,
> OK for master?

Ok

Richard 
> thanks
> Iain
> 
> --- 8< ---
> 
> We do not use the shared libffi library, nor do we install it.
> However, on at least Darwin, the shared version will be picked
> up for testing, so it is preferrable not to build it.
> 
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
> 
> ChangeLog:
> 
>    * Makefile.def: Do not build shared libffi.
>    * Makefile.in: Regenerate.
> ---
> Makefile.def | 3 ++-
> Makefile.in  | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.def b/Makefile.def
> index 86d15f1982f..35e994eb77e 100644
> --- a/Makefile.def
> +++ b/Makefile.def
> @@ -181,7 +181,8 @@ target_modules = { module= libtermcap; no_check=true;
>                    missing=maintainer-clean; };
> target_modules = { module= winsup; };
> target_modules = { module= libgloss; no_check=true; };
> -target_modules = { module= libffi; no_install=true; };
> +target_modules = { module= libffi; no_install=true;
> +                   extra_configure_flags='--disable-shared --with-pic'; };
> target_modules = { module= zlib; bootstrap=true; };
> target_modules = { module= rda; };
> target_modules = { module= libada; };
> diff --git a/Makefile.in b/Makefile.in
> index d66e6208fa2..06a9398e172 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -55467,7 +55467,7 @@ configure-target-libffi:
>      $$s/$$module_srcdir/configure \
>      --srcdir=$${topdir}/$$module_srcdir \
>      $(TARGET_CONFIGARGS) --build=${build_alias} --host=${target_alias} \
> -      --target=${target_alias}  \
> +      --target=${target_alias} --disable-shared --with-pic \
>      || exit 1
> @endif target-libffi
> 
> -- 
> 2.37.1 (Apple Git-137.1)
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-31 17:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-31 14:16 [PATCH] configure: Do not build the unused libffi shared library Iain Sandoe
2022-12-31 17:23 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).