From: Jeff Law <jeffreyalaw@gmail.com>
To: Thomas Neumann <thomas.neumann@in.tum.de>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>, Rainer Orth <ro@gcc.gnu.org>
Subject: Re: [PATCH] preserve base pointer for __deregister_frame [PR110956]
Date: Fri, 11 Aug 2023 09:21:38 -0600 [thread overview]
Message-ID: <86489fb4-d507-3aab-8000-baf3a2a23a55@gmail.com> (raw)
In-Reply-To: <ae3a8263-f29f-f8b2-0733-8dc1e3420859@in.tum.de>
On 8/10/23 05:33, Thomas Neumann via Gcc-patches wrote:
> Original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110956
> Rainer Orth successfully tested the patch on Solaris with a full bootstrap.
>
>
>
> Some uncommon unwinding table encodings need to access the base pointer
> for address computations. We do not have that information in calls to
> __deregister_frame_info_bases, and previously simply used nullptr as
> base pointer. That is usually fine, but for some Solaris i386 shared
> libraries that results in wrong address computations.
>
> To fix this problem we now associate the unwinding object with
> the table pointer itself, which is always known, in addition to
> the PC range. When deregistering a frame, we first locate the object
> using the table pointer, and then use the base pointer stored within
> the object to compute the PC range.
>
> libgcc/ChangeLog:
> PR libgcc/110956
> * unwind-dw2-fde.c: Associate object with address of unwinding
> table.
Pushed to the trunk. Thanks.
Jeff
next prev parent reply other threads:[~2023-08-11 15:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 10:19 [PATCH v4] eliminate mutex in fast path of __register_frame Thomas Neumann
2022-09-16 14:49 ` Jason Merrill
2022-09-18 8:59 ` Dimitar Dimitrov
2022-09-18 9:20 ` Thomas Neumann
2022-09-18 10:02 ` Thomas Neumann
2022-09-19 13:46 ` Stephan Bergmann
2022-09-19 13:55 ` Thomas Neumann
2022-09-19 14:00 ` Stephan Bergmann
2022-09-19 15:33 ` Thomas Neumann
2022-09-20 5:39 ` Stephan Bergmann
2022-11-21 11:14 ` Tamar Christina
2022-11-21 11:22 ` Thomas Neumann
2022-11-21 11:48 ` Jakub Jelinek
2022-11-21 17:13 ` H.J. Lu
2022-11-22 0:31 ` Thomas Neumann
2022-11-22 8:20 ` Florian Weimer
2022-11-22 9:12 ` Thomas Neumann
2022-12-09 17:34 ` [PATCH] initialize fde objects lazily Thomas Neumann
2022-12-15 16:11 ` Tamar Christina
2022-12-16 17:25 ` Jason Merrill
2023-05-02 14:32 ` [PATCH] release the sorted FDE array when deregistering a frame [PR109685] Thomas Neumann
2023-05-10 10:49 ` [PATCH] fix radix sort on 32bit platforms [PR109670] Thomas Neumann
2023-08-10 11:33 ` [PATCH] preserve base pointer for __deregister_frame [PR110956] Thomas Neumann
2023-08-11 15:21 ` Jeff Law [this message]
2024-03-15 10:29 ` [PATCH] handle unwind tables that are embedded within unwinding code, [PR111731] Thomas Neumann
2024-03-20 8:25 ` Richard Biener
2024-03-22 13:35 ` Jeff Law
2024-03-22 13:36 ` Jeff Law
2024-03-22 14:43 ` Thomas Neumann
2022-11-22 8:00 ` [PATCH] speed up end_fde_sort using radix sort Thomas Neumann
2022-12-16 18:02 ` Jason Merrill
2022-11-21 11:49 ` [PATCH v4] eliminate mutex in fast path of __register_frame Tamar Christina
2022-11-21 11:53 ` Thomas Neumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86489fb4-d507-3aab-8000-baf3a2a23a55@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ro@gcc.gnu.org \
--cc=thomas.neumann@in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).