From: Jeff Law <jeffreyalaw@gmail.com>
To: shiyulong@iscas.ac.cn, gcc-patches@gcc.gnu.org
Cc: palmer@dabbelt.com, kito.cheng@sifive.com,
jim.wilson.gcc@gmail.com, wuwei2016@iscas.ac.cn,
jiawei@iscas.ac.cn, shihua@iscas.ac.cn, dje.gcc@gmail.com,
mirimmad@outlook.com, pinskia@gmail.com
Subject: Re: [PATCH V2] RISC-V: Modified validation information for contracts-tmpl-spec2.C
Date: Fri, 28 Apr 2023 15:53:01 -0600 [thread overview]
Message-ID: <86d25964-7145-6c4b-8794-df0d521a14bb@gmail.com> (raw)
In-Reply-To: <20230407033702.6770-2-shiyulong@iscas.ac.cn>
On 4/6/23 21:37, shiyulong@iscas.ac.cn wrote:
> From: yulong <shiyulong@iscas.ac.cn>
>
> This patch fixes the problem of the contracts-tmpl-spec2.c running failure.
> When run the dejagnu test, I find that the output is inconsistent with that verified
> in the testcase. So I try to modify it, and then it can be passed.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/contracts/contracts-tmpl-spec2.C:delete some output information
I think you need to debug why you get different output from this test.
Just removing the output because it didn't match on risc-v seems wrong.
jeff
next prev parent reply other threads:[~2023-04-28 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 3:37 [PATCH V4] RISC-V: Fix a redefinition bug for the fd-4.c shiyulong
2023-04-07 3:37 ` [PATCH V2] RISC-V: Modified validation information for contracts-tmpl-spec2.C shiyulong
2023-04-28 21:53 ` Jeff Law [this message]
2023-04-08 18:46 ` [PATCH V4] RISC-V: Fix a redefinition bug for the fd-4.c Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d25964-7145-6c4b-8794-df0d521a14bb@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiawei@iscas.ac.cn \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=mirimmad@outlook.com \
--cc=palmer@dabbelt.com \
--cc=pinskia@gmail.com \
--cc=shihua@iscas.ac.cn \
--cc=shiyulong@iscas.ac.cn \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).