* Re: [PATCH] Use toplevel configure for GMP and MPFR for gdb [not found] <1667924955-9218-1-git-send-email-apinski@marvell.com> @ 2022-11-08 16:46 ` Andreas Schwab 2022-11-08 16:55 ` Andrew Pinski 2022-11-10 16:25 ` Tom Tromey 1 sibling, 1 reply; 3+ messages in thread From: Andreas Schwab @ 2022-11-08 16:46 UTC (permalink / raw) To: apinski--- via Gcc-patches; +Cc: binutils, gdb-patches, gcc-patches, apinski On Nov 08 2022, apinski--- via Gcc-patches wrote: > diff --git a/configure b/configure > index 7bcb894d1fe..9ee7a1a3abe 100755 > --- a/configure > +++ b/configure > @@ -769,6 +769,7 @@ infodir > docdir > oldincludedir > includedir > +runstatedir > localstatedir > sharedstatedir > sysconfdir Please avoid using a patched autoconf command. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use toplevel configure for GMP and MPFR for gdb 2022-11-08 16:46 ` [PATCH] Use toplevel configure for GMP and MPFR for gdb Andreas Schwab @ 2022-11-08 16:55 ` Andrew Pinski 0 siblings, 0 replies; 3+ messages in thread From: Andrew Pinski @ 2022-11-08 16:55 UTC (permalink / raw) To: Andreas Schwab Cc: apinski--- via Gcc-patches, binutils, gdb-patches, gcc-patches, apinski On Tue, Nov 8, 2022 at 8:46 AM Andreas Schwab via Gdb-patches <gdb-patches@sourceware.org> wrote: > > On Nov 08 2022, apinski--- via Gcc-patches wrote: > > > diff --git a/configure b/configure > > index 7bcb894d1fe..9ee7a1a3abe 100755 > > --- a/configure > > +++ b/configure > > @@ -769,6 +769,7 @@ infodir > > docdir > > oldincludedir > > includedir > > +runstatedir > > localstatedir > > sharedstatedir > > sysconfdir > > Please avoid using a patched autoconf command. Sorry about that. I have regenerated it with a plain autoconfig-2.69 and will make sure I will be using that going forward and when approved use that with the pushed version but I don't see a reason to resubmit the patch otherwise. Thanks, Andrew Pinski > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different." ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use toplevel configure for GMP and MPFR for gdb [not found] <1667924955-9218-1-git-send-email-apinski@marvell.com> 2022-11-08 16:46 ` [PATCH] Use toplevel configure for GMP and MPFR for gdb Andreas Schwab @ 2022-11-10 16:25 ` Tom Tromey 1 sibling, 0 replies; 3+ messages in thread From: Tom Tromey @ 2022-11-10 16:25 UTC (permalink / raw) To: apinski--- via Gcc-patches; +Cc: binutils, gdb-patches, gcc-patches, apinski >>>>> "Andrew" == apinski--- via Gcc-patches <gcc-patches@gcc.gnu.org> writes: Andrew> From: Andrew Pinski <apinski@marvell.com> Andrew> This patch uses the toplevel configure parts for GMP/MPFR for Andrew> gdb. The only thing is that gdb now requires MPFR for building. Andrew> Before it was a recommended but not required library. Andrew> Also this allows building of GMP and MPFR with the toplevel Andrew> directory just like how it is done for GCC. Andrew> We now error out in the toplevel configure of the version Andrew> of GMP and MPFR that is wrong. Thank you for doing this. It's been on my to-do list to investigate this for quite a while, but I never got to it... :( One larger question I have is whether we should land this now, or wait until after GDB 13 branches. That is coming soon and maybe it's not good to add a new dependency just before the release. My inclination would be to defer it, I suppose out of conservatism, but I'd appreciate hearing from others. I think gdb/README and gdb/doc/gdb.texinfo need some minor changes, because the GMP-related configure options are being renamed. The commit message should mention "PR build/28500" somewhere so that the commit is logged to bugzilla. Also in gdb we've been using a "Bug:" trailer in the commit message that has the full URL of the bug. IIUC this does fix that PR. Tom ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-10 16:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1667924955-9218-1-git-send-email-apinski@marvell.com> 2022-11-08 16:46 ` [PATCH] Use toplevel configure for GMP and MPFR for gdb Andreas Schwab 2022-11-08 16:55 ` Andrew Pinski 2022-11-10 16:25 ` Tom Tromey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).