From: Florian Weimer <fweimer@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/3] Compute a table of DWARF register sizes at compile
Date: Mon, 02 Jan 2023 16:20:13 +0100 [thread overview]
Message-ID: <874jt9netu.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <e8a32e4a-9ed4-7df5-5397-ac545e87a71b@gmail.com> (Jeff Law's message of "Sun, 20 Nov 2022 08:23:18 -0700")
* Jeff Law:
> On 11/8/22 11:05, Florian Weimer via Gcc-patches wrote:
>> The sizes are compile-time constants. Create a vector with them,
>> so that they can be inspected at compile time.
>>
>> * gcc/dwarf2cfi.cc (init_return_column_size): Remove.
>> (init_one_dwarf_reg_size): Adjust.
>> (generate_dwarf_reg_sizes): New function. Extracted
>> from expand_builtin_init_dwarf_reg_sizes.
>> (expand_builtin_init_dwarf_reg_sizes): Call
>> generate_dwarf_reg_sizes.
>> * gcc/target.def (init_dwarf_reg_sizes_extra): Adjust
>> hook signature.
>> * gcc/config/msp430/msp430.cc
>> (msp430_init_dwarf_reg_sizes_extra): Adjust.
>> * gcc/config/rs6000.cc (rs6000_init_dwarf_reg_sizes_extra):
>> Likewise.
>> * gcc/doc/tm.texi: Update.
>
> This series of 3 patches is fine.
Thanks, now pushed (after polishing the ChangeLog snippets).
Florian
next prev parent reply other threads:[~2023-01-02 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 18:05 [PATCH 0/3] Further libgcc unwinder improvements Florian Weimer
2022-11-08 18:05 ` [PATCH 1/3] Compute a table of DWARF register sizes at compile Florian Weimer
2022-11-20 15:23 ` Jeff Law
2023-01-02 15:20 ` Florian Weimer [this message]
2022-11-08 18:05 ` [PATCH 2/3] Define __LIBGCC_DWARF_REG_SIZES_CONSTANT__ if DWARF register size is constant Florian Weimer
2022-11-08 18:05 ` [PATCH 3/3] libgcc: Specialize execute_cfa_program in DWARF unwinder for alignments Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jt9netu.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).