* [PATCH v4] bpf: fixed template for neg (added second operand)
@ 2023-07-21 18:19 Cupertino Miranda
2023-07-21 18:21 ` Jose E. Marchesi
0 siblings, 1 reply; 2+ messages in thread
From: Cupertino Miranda @ 2023-07-21 18:19 UTC (permalink / raw)
To: gcc-patches; +Cc: elena.zannoni, jose.marchesi, david.faust, Cupertino Miranda
This patch fixes define_insn for "neg" to support 2 operands.
Initial implementation assumed the format "neg %0" while the instruction
allows both a destination and source operands. The second operand can
either be a register or an immediate value.
gcc/ChangeLog:
* config/bpf/bpf.md: fixed template for neg instruction.
---
gcc/config/bpf/bpf.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
index 329f62f55c33..adf11e151df1 100644
--- a/gcc/config/bpf/bpf.md
+++ b/gcc/config/bpf/bpf.md
@@ -139,10 +139,10 @@
;;; Negation
(define_insn "neg<AM:mode>2"
- [(set (match_operand:AM 0 "register_operand" "=r")
- (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
+ [(set (match_operand:AM 0 "register_operand" "=r,r")
+ (neg:AM (match_operand:AM 1 "register_operand" " r,I")))]
""
- "neg<msuffix>\t%0"
+ "neg<msuffix>\t%0,%1"
[(set_attr "type" "<mtype>")])
;;; Multiplication
--
2.38.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4] bpf: fixed template for neg (added second operand)
2023-07-21 18:19 [PATCH v4] bpf: fixed template for neg (added second operand) Cupertino Miranda
@ 2023-07-21 18:21 ` Jose E. Marchesi
0 siblings, 0 replies; 2+ messages in thread
From: Jose E. Marchesi @ 2023-07-21 18:21 UTC (permalink / raw)
To: Cupertino Miranda; +Cc: gcc-patches, elena.zannoni, david.faust
Better with the commit message.
OK. Thanks.
> This patch fixes define_insn for "neg" to support 2 operands.
> Initial implementation assumed the format "neg %0" while the instruction
> allows both a destination and source operands. The second operand can
> either be a register or an immediate value.
>
> gcc/ChangeLog:
>
> * config/bpf/bpf.md: fixed template for neg instruction.
> ---
> gcc/config/bpf/bpf.md | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 329f62f55c33..adf11e151df1 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -139,10 +139,10 @@
>
> ;;; Negation
> (define_insn "neg<AM:mode>2"
> - [(set (match_operand:AM 0 "register_operand" "=r")
> - (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
> + [(set (match_operand:AM 0 "register_operand" "=r,r")
> + (neg:AM (match_operand:AM 1 "register_operand" " r,I")))]
> ""
> - "neg<msuffix>\t%0"
> + "neg<msuffix>\t%0,%1"
> [(set_attr "type" "<mtype>")])
>
> ;;; Multiplication
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-21 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 18:19 [PATCH v4] bpf: fixed template for neg (added second operand) Cupertino Miranda
2023-07-21 18:21 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).