Re: [PATCH] libiberty: Fix C89-isms in configure tests

[Florian Weimer <fweimer@redhat.com>]

* Jakub Jelinek:

> On Tue, Oct 18, 2022 at 12:05:49PM +0200, Florian Weimer via Gcc-patches wrote:
>> libiberty/
>> 
>> 	* acinclude.m4 (check for working strncmp): Add missing
>> 	int return type and parameter list to the definition of main.
>> 	Include <string.h> for string functions.  Avoid calling
>> 	undeclared exit function.
>>         (stack direction for C alloca): Avoid calling undeclared exit
>>         function.
>
> Spaces instead of tabs.

You mean I should use tabs throughout, right?

> I'd think we should #include <stdlib.h> for exit and keep exit, I vaguely
> remember non-zero return from main doesn't always work reliably, which is
> why e.g. in the testsuite we usually abort instead of return non-zero
> from main.  Don't remember if it is just for some bare metal cases or
> what, which on the either side probably don't have mmap.

Okay, will do that and send a v2.

By the way, the stack direction test currently gives incorrect results
on x86-64 due to -O2 and address comparison of unrelated objects.  I
assume this doesn't matter because we don't use it on compilers that
support alloca natively.

Thanks,
Florian