From: Florian Weimer <fweimer@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libiberty: Fix C89-isms in configure tests
Date: Tue, 18 Oct 2022 16:14:53 +0200 [thread overview]
Message-ID: <87r0z5i5gi.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Y06zWAbIbPezn6Ba@tucnak> (Jakub Jelinek's message of "Tue, 18 Oct 2022 16:08:24 +0200")
* Jakub Jelinek:
> On Tue, Oct 18, 2022 at 04:06:17PM +0200, Florian Weimer wrote:
>> By the way, the stack direction test currently gives incorrect results
>> on x86-64 due to -O2 and address comparison of unrelated objects. I
>> assume this doesn't matter because we don't use it on compilers that
>> support alloca natively.
>
> Guess it would be better to cast the addresses to uintptr_t and
> compare that.
But can we assume that uintptr_t is defined? Or that <stdint.h> exists?
Thanks,
Florian
next prev parent reply other threads:[~2022-10-18 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 10:05 Florian Weimer
2022-10-18 12:57 ` Jakub Jelinek
2022-10-18 14:06 ` Florian Weimer
2022-10-18 14:08 ` Jakub Jelinek
2022-10-18 14:14 ` Florian Weimer [this message]
2022-10-18 14:19 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0z5i5gi.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).