From: Joseph Myers <joseph@codesourcery.com>
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: Java front-end and library patches.
Date: Mon, 28 Nov 2022 22:35:31 +0000 [thread overview]
Message-ID: <87be1195-fee5-7355-ddd-ddceedcce0a6@codesourcery.com> (raw)
In-Reply-To: <CAEYL+X8Ps4JvNdnRuGru7Po8o9cUW5mJkDP1TAv9zuZM7K4wpg@mail.gmail.com>
On Fri, 25 Nov 2022, Zopolis0 via Gcc-patches wrote:
> Firstly, to get feedback and reviews on the 56 already existing
> patches, even though most are just re-adding code or making idiomatic
> changes, so that when the final issue is solved everything has already
> been approved (hopefully) and the merge is good to go.
I think a lot more explanation is needed to get much useful feedback.
* Each patch should have its own explanation of what it is doing and why,
in the message body (not in an attachment). Just the commit summary line
and ChangeLog entries aren't enough, we need the actual substantive commit
message explaining the patch.
* An overall explanation is needed of what the patch series is doing and
why. Why is it now considered useful to add this front end back? Which
version is the basis of the one being added back - the version removed
from GCC (that used ECJ for converting Java source to Java byte-code), or
some other version? How has the series been validated? Would you propose
to maintain the front end and libraries in future? Would you re-open any
bugs against the front end or libraries that were closed (as WONTFIX or
otherwise) as a result of it being removed from the tree (maybe when it
was removed, maybe later when the last release series with the front end
ceased to be supported)? And so on.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-11-28 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:37 Zopolis0
2022-11-28 22:35 ` Joseph Myers [this message]
2022-11-30 12:18 ` Zopolis0
2022-11-30 12:50 ` Xi Ruoyao
2022-11-30 18:22 ` Joseph Myers
2022-12-01 11:50 ` Thomas Schwinge
2022-12-02 0:24 ` Zopolis0
2022-12-02 0:26 ` Zopolis0
2022-12-06 11:24 ` Zopolis0
2022-12-12 0:08 ` Zopolis0
2022-12-14 23:01 ` Zopolis0
2022-12-15 2:22 ` Zopolis0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87be1195-fee5-7355-ddd-ddceedcce0a6@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=creatorsmithmdt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).