From: Thomas Schwinge <thomas@codesourcery.com>
To: Julian Brown <julian@codesourcery.com>
Cc: <fortran@gcc.gnu.org>, <tobias@codesourcery.com>,
<jakub@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] OpenACC: Stand-alone attach/detach clause fixes for Fortran [PR109622]
Date: Fri, 28 Apr 2023 14:56:18 +0200 [thread overview]
Message-ID: <87bkj817yl.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <20230427183647.99112-1-julian@codesourcery.com>
Hi Julian!
On 2023-04-27T11:36:47-0700, Julian Brown <julian@codesourcery.com> wrote:
> This patch fixes several cases where multiple attach or detach mapping
> nodes were being created for stand-alone attach or detach clauses
> in Fortran. After the introduction of stricter checking later during
> compilation, these extra nodes could cause ICEs, as seen in the PR.
>
> The patch also fixes cases that "happened to work" previously where
> the user attaches/detaches a pointer to array using a descriptor, and
> (I think!) the "_data" field has offset zero, hence the same address as
> the descriptor as a whole.
Thanks for looking into this.
I haven't reviewed the patch itself, but noticed one thing:
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.fortran/pr109622-2.f90
> +!$acc enter data copyin(var)
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.fortran/pr109622-3.f90
> +!$acc enter data copyin(var, tgt)
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.fortran/pr109622.f90
> +!$acc enter data copyin(var, var2)
You'll want to move these into 'libgomp/testsuite/libgomp.oacc-fortran/'
to actually test them with '-fopenacc' instead of '-fopenmp'. ;-)
Chalk up one for the idea that I once had, to have '-fopenacc',
'-fopenmp', '-fopenmp-simd' enable '-Wunknown-pragmas' by default.
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2023-04-28 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <138a36f7-8b1e-5955-1d3a-5713a0fcf5b6@univ-grenoble-alpes.fr>
2023-04-27 18:36 ` Julian Brown
2023-04-28 8:16 ` Tobias Burnus
2023-04-28 12:56 ` Thomas Schwinge [this message]
2023-04-29 10:57 ` [PATCH] OpenACC: Further " Julian Brown
2023-05-02 10:29 ` Tobias Burnus
2023-05-03 12:59 ` Julian Brown
2023-05-03 13:50 ` Tobias Burnus
2023-05-03 11:29 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkj817yl.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=julian@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).