From: Jeff Law <jeffreyalaw@gmail.com>
To: "Robin Dapp" <rdapp.gcc@gmail.com>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
丁乐华 <lehua.ding@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]
Date: Wed, 14 Jun 2023 13:05:16 -0600 [thread overview]
Message-ID: <87cfd0c0-4e59-4cf8-1e72-eb9e1dc78c5f@gmail.com> (raw)
In-Reply-To: <33729abc-b810-c060-17b6-05df0f35612e@gmail.com>
On 6/14/23 06:05, Robin Dapp via Gcc-patches wrote:
>> Oh. I see Robin's email is also wrong. CC Robin too for you....
>
> It still arrived via the mailing list ;)
>
>> Good to see a Fix patch of the ICE before Vector ABI patch.
>> Let's wait for more comments.
>
> LGTM, this way I don't even need to rewrite my tests.
I think Palmer wanted to include a pointer to the psabi MR, so we should
probably include that in a comment. So OK with that in a comment.
I think there was talk of having this all be hidden behind a flag, but
given it's an ICE on vector types, I don't mind just defining something
for now to fix the ICE and give psabi time to finalize that spec.
This was also a good reminder that the vector work can't really be
complete until we have the psabi updates in place and implemented. The
efforts can obviously continue in parallel, but it's a dependency worth
noting in the RISE context.
Jeff
next prev parent reply other threads:[~2023-06-14 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:56 Lehua Ding
2023-06-14 11:59 ` juzhe.zhong
2023-06-14 12:01 ` juzhe.zhong
2023-06-14 18:59 ` Jeff Law
2023-06-14 12:03 ` juzhe.zhong
2023-06-14 12:05 ` Robin Dapp
2023-06-14 19:05 ` Jeff Law [this message]
2023-06-14 19:07 ` Jeff Law
2023-06-15 1:34 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cfd0c0-4e59-4cf8-1e72-eb9e1dc78c5f@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=lehua.ding@rivai.ai \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).