* [PATCH] bpf: Delayed the removal of the parser enum plugin handler.
@ 2023-11-13 22:35 Cupertino Miranda
2023-11-14 16:49 ` David Faust
0 siblings, 1 reply; 3+ messages in thread
From: Cupertino Miranda @ 2023-11-13 22:35 UTC (permalink / raw)
To: gcc-patches; +Cc: jose.marchesi, elena.zannoni, david.faust, Cupertino Miranda
The parser plugin handler that is responsible for collecting enum values
information was being removed way too early.
bpf_resolve_overloaded_core_builtin is called by the parser.
It was moved to the function execute_lower_bpf_core.
gcc/ChangeLog:
* config/bpf/core-builtins.cc
(bpf_resolve_overloaded_core_builtin): Removed call.
(execute_lower_bpf_core): Added all to remove_parser_plugin.
---
gcc/config/bpf/core-builtins.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gcc/config/bpf/core-builtins.cc b/gcc/config/bpf/core-builtins.cc
index a224847d5d91..2ba78d7aed2e 100644
--- a/gcc/config/bpf/core-builtins.cc
+++ b/gcc/config/bpf/core-builtins.cc
@@ -1473,8 +1473,6 @@ tree
bpf_resolve_overloaded_core_builtin (location_t loc, tree fndecl,
void *arglist)
{
- remove_parser_plugin ();
-
if (!bpf_require_core_support ())
return error_mark_node;
@@ -1688,6 +1686,7 @@ make_gimple_core_safe_access_index (tree *tp,
static unsigned int
execute_lower_bpf_core (void)
{
+ remove_parser_plugin ();
if (!TARGET_BPF_CORE)
return 0;
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: Delayed the removal of the parser enum plugin handler.
2023-11-13 22:35 [PATCH] bpf: Delayed the removal of the parser enum plugin handler Cupertino Miranda
@ 2023-11-14 16:49 ` David Faust
2023-11-28 12:40 ` Cupertino Miranda
0 siblings, 1 reply; 3+ messages in thread
From: David Faust @ 2023-11-14 16:49 UTC (permalink / raw)
To: Cupertino Miranda; +Cc: gcc-patches, jose.marchesi, elena.zannoni
On 11/13/23 14:35, Cupertino Miranda wrote:
> The parser plugin handler that is responsible for collecting enum values
> information was being removed way too early.
> bpf_resolve_overloaded_core_builtin is called by the parser.
> It was moved to the function execute_lower_bpf_core.
>
OK, thanks.
> gcc/ChangeLog:
> * config/bpf/core-builtins.cc
> (bpf_resolve_overloaded_core_builtin): Removed call.
> (execute_lower_bpf_core): Added all to remove_parser_plugin.
> ---
> gcc/config/bpf/core-builtins.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gcc/config/bpf/core-builtins.cc b/gcc/config/bpf/core-builtins.cc
> index a224847d5d91..2ba78d7aed2e 100644
> --- a/gcc/config/bpf/core-builtins.cc
> +++ b/gcc/config/bpf/core-builtins.cc
> @@ -1473,8 +1473,6 @@ tree
> bpf_resolve_overloaded_core_builtin (location_t loc, tree fndecl,
> void *arglist)
> {
> - remove_parser_plugin ();
> -
> if (!bpf_require_core_support ())
> return error_mark_node;
>
> @@ -1688,6 +1686,7 @@ make_gimple_core_safe_access_index (tree *tp,
> static unsigned int
> execute_lower_bpf_core (void)
> {
> + remove_parser_plugin ();
> if (!TARGET_BPF_CORE)
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: Delayed the removal of the parser enum plugin handler.
2023-11-14 16:49 ` David Faust
@ 2023-11-28 12:40 ` Cupertino Miranda
0 siblings, 0 replies; 3+ messages in thread
From: Cupertino Miranda @ 2023-11-28 12:40 UTC (permalink / raw)
To: David Faust; +Cc: gcc-patches, jose.marchesi, elena.zannoni
Thanks!! Commited !
David Faust writes:
> On 11/13/23 14:35, Cupertino Miranda wrote:
>> The parser plugin handler that is responsible for collecting enum values
>> information was being removed way too early.
>> bpf_resolve_overloaded_core_builtin is called by the parser.
>> It was moved to the function execute_lower_bpf_core.
>>
>
> OK, thanks.
>
>> gcc/ChangeLog:
>> * config/bpf/core-builtins.cc
>> (bpf_resolve_overloaded_core_builtin): Removed call.
>> (execute_lower_bpf_core): Added all to remove_parser_plugin.
>> ---
>> gcc/config/bpf/core-builtins.cc | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/gcc/config/bpf/core-builtins.cc b/gcc/config/bpf/core-builtins.cc
>> index a224847d5d91..2ba78d7aed2e 100644
>> --- a/gcc/config/bpf/core-builtins.cc
>> +++ b/gcc/config/bpf/core-builtins.cc
>> @@ -1473,8 +1473,6 @@ tree
>> bpf_resolve_overloaded_core_builtin (location_t loc, tree fndecl,
>> void *arglist)
>> {
>> - remove_parser_plugin ();
>> -
>> if (!bpf_require_core_support ())
>> return error_mark_node;
>>
>> @@ -1688,6 +1686,7 @@ make_gimple_core_safe_access_index (tree *tp,
>> static unsigned int
>> execute_lower_bpf_core (void)
>> {
>> + remove_parser_plugin ();
>> if (!TARGET_BPF_CORE)
>> return 0;
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-28 12:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 22:35 [PATCH] bpf: Delayed the removal of the parser enum plugin handler Cupertino Miranda
2023-11-14 16:49 ` David Faust
2023-11-28 12:40 ` Cupertino Miranda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).