From: Andreas Schwab <schwab@linux-m68k.org>
To: Patrick O'Neill <patrick@rivosinc.com>
Cc: gcc-patches@gcc.gnu.org, rep.dot.nop@gmail.com, jeffreyalaw@gmail.com
Subject: Re: [PATCH] RISC-V: Fix sync.md and riscv.cc whitespace errors
Date: Wed, 26 Apr 2023 23:10:01 +0200 [thread overview]
Message-ID: <87ildi2vva.fsf@igel.home> (raw)
In-Reply-To: <20230426205349.1131469-1-patrick@rivosinc.com> (Patrick O'Neill's message of "Wed, 26 Apr 2023 13:53:49 -0700")
On Apr 26 2023, Patrick O'Neill wrote:
> @@ -290,10 +290,10 @@
> [(set (match_operand:GPR 0 "register_operand" "=&r")
> (match_operand:GPR 1 "memory_operand" "+A"))
> (set (match_dup 1)
> - (unspec_volatile:GPR [(match_operand:GPR 2 "reg_or_0_operand" "rJ")
> - (match_operand:GPR 3 "reg_or_0_operand" "rJ")
> - (match_operand:SI 4 "const_int_operand") ;; mod_s
> - (match_operand:SI 5 "const_int_operand")] ;; mod_f
> + (unspec_volatile:GPR[(match_operand:GPR 2 "reg_or_0_operand" "rJ")
> + (match_operand:GPR 3 "reg_or_0_operand" "rJ")
> + (match_operand:SI 4 "const_int_operand") ;; mod_s
> + (match_operand:SI 5 "const_int_operand")] ;; mod_f
That appears to be a bug in the checker. This isn't a C array
expression, but an argument in lispy vector notation, so it should be
separated by a space.
> @@ -431,15 +431,15 @@
> })
>
> (define_insn "subword_atomic_cas_strong"
> - [(set (match_operand:SI 0 "register_operand" "=&r") ;; old value at mem
> - (match_operand:SI 1 "memory_operand" "+A")) ;; mem location
> + [(set (match_operand:SI 0 "register_operand" "=&r") ;; old value at mem
> + (match_operand:SI 1 "memory_operand" "+A")) ;; mem location
> (set (match_dup 1)
> - (unspec_volatile:SI [(match_operand:SI 2 "reg_or_0_operand" "rJ") ;; expected value
> - (match_operand:SI 3 "reg_or_0_operand" "rJ")] ;; desired value
> + (unspec_volatile:SI[(match_operand:SI 2 "reg_or_0_operand" "rJ") ;; expected value
> + (match_operand:SI 3 "reg_or_0_operand" "rJ")] ;; desired value
Likewise.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-04-26 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 20:53 Patrick O'Neill
2023-04-26 21:10 ` Andreas Schwab [this message]
2023-04-26 21:41 ` Bernhard Reutner-Fischer
2023-04-26 21:21 ` [PATCH v2] " Patrick O'Neill
2023-04-26 21:45 ` Bernhard Reutner-Fischer
2023-04-26 21:59 ` Patrick O'Neill
2023-04-27 6:21 ` Bernhard Reutner-Fischer
2023-04-26 23:12 ` [committed] " Patrick O'Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ildi2vva.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=patrick@rivosinc.com \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).