From: Thomas Schwinge <thomas@codesourcery.com>
To: "Martin Liška" <mliska@suse.cz>,
"Richard Biener" <richard.guenther@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality
Date: Fri, 4 Nov 2022 10:32:20 +0100 [thread overview]
Message-ID: <87k04b2hgb.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <10a94ccc-e01b-b98a-0fcb-cd661c10c315@suse.cz>
Hi!
On 2022-09-01T12:05:23+0200, Martin Liška <mliska@suse.cz> wrote:
> gcc/ChangeLog:
> --- a/gcc/system.h
> +++ b/gcc/system.h
> @@ -1009,8 +1009,7 @@ extern void fancy_abort (const char *, int, const char *)
> ASM_OUTPUT_DEFINE_LABEL_DIFFERENCE_SYMBOL HOST_WORDS_BIG_ENDIAN \
> OBJC_PROLOGUE ALLOCATE_TRAMPOLINE HANDLE_PRAGMA ROUND_TYPE_SIZE \
> ROUND_TYPE_SIZE_UNIT CONST_SECTION_ASM_OP CRT_GET_RFIB_TEXT \
> - DBX_LBRAC_FIRST DBX_OUTPUT_ENUM DBX_OUTPUT_SOURCE_FILENAME \
> - DBX_WORKING_DIRECTORY INSN_CACHE_DEPTH INSN_CACHE_SIZE \
> + INSN_CACHE_DEPTH INSN_CACHE_SIZE \
> INSN_CACHE_LINE_WIDTH INIT_SECTION_PREAMBLE NEED_ATEXIT ON_EXIT \
> EXIT_BODY OBJECT_FORMAT_ROSE MULTIBYTE_CHARS MAP_CHARACTER \
> LIBGCC_NEEDS_DOUBLE FINAL_PRESCAN_LABEL DEFAULT_CALLER_SAVES \
> @@ -1023,15 +1022,14 @@ extern void fancy_abort (const char *, int, const char *)
> MAX_WCHAR_TYPE_SIZE SHARED_SECTION_ASM_OP INTEGRATE_THRESHOLD \
> FINAL_REG_PARM_STACK_SPACE MAYBE_REG_PARM_STACK_SPACE \
> TRADITIONAL_PIPELINE_INTERFACE DFA_PIPELINE_INTERFACE \
> - DBX_OUTPUT_STANDARD_TYPES BUILTIN_SETJMP_FRAME_VALUE \
> + BUILTIN_SETJMP_FRAME_VALUE \
> SUNOS4_SHARED_LIBRARIES PROMOTE_FOR_CALL_ONLY \
> SPACE_AFTER_L_OPTION NO_RECURSIVE_FUNCTION_CSE \
> DEFAULT_MAIN_RETURN TARGET_MEM_FUNCTIONS EXPAND_BUILTIN_VA_ARG \
> COLLECT_PARSE_FLAG DWARF2_GENERATE_TEXT_SECTION_LABEL WINNING_GDB \
> ASM_OUTPUT_FILENAME ASM_OUTPUT_SOURCE_LINE FILE_NAME_JOINER \
> - GDB_INV_REF_REGPARM_STABS_LETTER DBX_MEMPARM_STABS_LETTER \
> - PUT_SDB_SRC_FILE STABS_GCC_MARKER DBX_OUTPUT_FUNCTION_END \
> - DBX_OUTPUT_GCC_MARKER DBX_FINISH_SYMBOL SDB_GENERATE_FAKE \
> + GDB_INV_REF_REGPARM_STABS_LETTER \
> + PUT_SDB_SRC_FILE STABS_GCC_MARKER SDB_GENERATE_FAKE \
> NON_SAVING_SETJMP TARGET_LATE_RTL_PROLOGUE_EPILOGUE \
> CASE_DROPS_THROUGH TARGET_BELL TARGET_BS TARGET_CR TARGET_DIGIT0 \
> TARGET_ESC TARGET_FF TARGET_NEWLINE TARGET_TAB TARGET_VT \
> @@ -1056,8 +1054,8 @@ extern void fancy_abort (const char *, int, const char *)
> PREFERRED_OUTPUT_RELOAD_CLASS SYSTEM_INCLUDE_DIR \
> STANDARD_INCLUDE_DIR STANDARD_INCLUDE_COMPONENT \
> LINK_ELIMINATE_DUPLICATE_LDIRECTORIES MIPS_DEBUGGING_INFO \
> - IDENT_ASM_OP ALL_COP_ADDITIONAL_REGISTER_NAMES DBX_OUTPUT_LBRAC \
> - DBX_OUTPUT_NFUN DBX_OUTPUT_RBRAC RANGE_TEST_NON_SHORT_CIRCUIT \
> + IDENT_ASM_OP ALL_COP_ADDITIONAL_REGISTER_NAMES \
> + RANGE_TEST_NON_SHORT_CIRCUIT \
> REAL_VALUE_TRUNCATE REVERSE_CONDEXEC_PREDICATES_P \
> TARGET_ALIGN_ANON_BITFIELDS TARGET_NARROW_VOLATILE_BITFIELDS \
> IDENT_ASM_OP UNALIGNED_SHORT_ASM_OP UNALIGNED_INT_ASM_OP \
These changes are part of
commit r13-2361-g7e0db0cdf01e9c885a29cb37415f5bc00d90c029
"STABS: remove -gstabs and -gxcoff functionality". What this does is
remove these identifiers from "poisoning":
/* As the last action in this file, we poison the identifiers that
shouldn't be used.
[...]
/* Other obsolete target macros, or macros that used to be in target
headers and were not used, and may be obsolete or may never have
been used. */
#pragma GCC poison [...]
Shouldn't these identifiers actually stay (so that any accidental future
use gets flagged, as I understand this machinery), and instead more
identifiers be added potentially: those where their definition/use got
removed with "STABS: remove -gstabs and -gxcoff functionality"? (I've
not checked.)
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2022-11-04 9:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 10:05 Martin Liška
2022-09-01 10:05 ` Martin Liška
2022-09-01 11:18 ` Richard Biener
2022-09-02 7:00 ` Martin Liška
2022-09-02 8:54 ` Richard Biener
2022-09-05 7:59 ` Martin Liška
2022-09-05 9:05 ` Richard Biener
2022-09-14 12:19 ` [COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality) Jan-Benedict Glaw
2022-09-14 13:20 ` Martin Liška
2022-10-10 14:19 ` Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' " Thomas Schwinge
2022-10-10 14:23 ` Tom de Vries
2022-10-11 6:40 ` Richard Biener
2022-11-04 9:12 ` Better integrate default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR') Thomas Schwinge
2022-10-12 9:21 ` Restore default 'sorry' 'TARGET_ASM_CONSTRUCTOR', 'TARGET_ASM_DESTRUCTOR' (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality) Martin Liška
2022-11-04 9:04 ` Thomas Schwinge
2022-11-04 9:07 ` Thomas Schwinge
2022-11-04 9:32 ` Thomas Schwinge [this message]
2022-11-10 14:02 ` [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality Martin Liška
2022-11-10 14:12 ` Michael Matz
2022-11-10 14:13 ` Martin Liška
2022-09-06 16:31 David Edelsohn
2022-09-06 17:00 ` David Edelsohn
2022-09-07 11:46 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k04b2hgb.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).