From: "Martin Liška" <mliska@suse.cz>
To: David Edelsohn <dje.gcc@gmail.com>,
Richard Biener <rguenther@suse.de>,
Jeff Law <jeffreyalaw@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality
Date: Wed, 7 Sep 2022 13:46:57 +0200 [thread overview]
Message-ID: <6aa8bbe6-6c63-ea82-85b0-fde91d459022@suse.cz> (raw)
In-Reply-To: <CAGWvnykp0i-AVyoE5jy-tCayjL0zg1Pgb1p8LvzC6pFSP7bFSA@mail.gmail.com>
On 9/6/22 19:00, David Edelsohn wrote:
> * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise.
> (HAVE_XCOFF_DWARF_EXTRAS): Likewise.
> (output_fde): Likewise.
> (output_call_frame_info): Likewise.
> (have_macinfo): Likewise.
> (add_AT_loc_list): Likewise.
> (add_AT_view_list): Likewise.
> (output_compilation_unit_header): Likewise.
> (output_pubnames): Likewise.
> (output_aranges): Likewise.
> (output_line_info): Likewise.
> (output_macinfo): Likewise.
> (dwarf2out_finish): Likewise.
> (dwarf2out_early_finish): Likewise.
>
> These changes are not correct and break AIX bootstrap.
>
> Those changes are not related to stabs support. We agreed to remove stabs and
>
> XCOFF stabs support, not GCC DWARF debugging support for AIX.
Sorry for the breakage, I've just sent a patch that restores that.
Cheers,
Martin
>
> Also
>
> * configure: Regenerate. Likewise.
> * configure.ac <http://configure.ac>: Likewise.
>
> does not list that tests for HAVE_XCOFF_DWARF_EXTRAS was removed, so the ChangeLog was not accurate.
>
> Again, that test is required for AIX is not part of stabs support.
>
>
> Please revert this change so that AIX can continue to be bootstrapped and tested, and we can work together to test a corrected patch.
>
> Thanks, David
>
>
> On Tue, Sep 6, 2022 at 12:31 PM David Edelsohn <dje.gcc@gmail.com <mailto:dje.gcc@gmail.com>> wrote:
>
> I fully support the plan to remove stabs support, but this patch broke bootstrap on AIX. It seems rather bad policy to remove support for a feature without ensuring that the removal does not negatively impact the targets touched by the patch. I should have been explicitly copied on these patches and I should have been asked to test the patches before they were installed, if for no other reason than politeness and consideration.
>
> Thanks, David
>
>
next prev parent reply other threads:[~2022-09-07 11:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:31 David Edelsohn
2022-09-06 17:00 ` David Edelsohn
2022-09-07 11:46 ` Martin Liška [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-01 10:05 Martin Liška
2022-09-01 10:05 ` Martin Liška
2022-09-01 11:18 ` Richard Biener
2022-09-02 7:00 ` Martin Liška
2022-09-02 8:54 ` Richard Biener
2022-09-05 7:59 ` Martin Liška
2022-09-05 9:05 ` Richard Biener
2022-11-04 9:32 ` Thomas Schwinge
2022-11-10 14:02 ` Martin Liška
2022-11-10 14:12 ` Michael Matz
2022-11-10 14:13 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa8bbe6-6c63-ea82-85b0-fde91d459022@suse.cz \
--to=mliska@suse.cz \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).