* [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
@ 2023-11-10 11:22 Florian Weimer
2023-11-29 15:27 ` Szabolcs Nagy
2023-11-29 15:31 ` Richard Earnshaw
0 siblings, 2 replies; 3+ messages in thread
From: Florian Weimer @ 2023-11-10 11:22 UTC (permalink / raw)
To: gcc-patches
This test looks like it intends to pass a small struct argument
through both a non-variadic and variadic argument, but due to
the typo, it does not achieve that.
gcc/testsuite/
* gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named.
---
gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
index 906ccebf616..edc35db2f6e 100644
--- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
@@ -16,6 +16,6 @@ void unnamed (int, ...);
void foo ()
{
- name (0, aaaa);
+ named (0, aaaa);
unnamed (0, aaaa);
}
base-commit: 5f6c5fe078c45bc32c8d21da6b14c27c0ed7be6e
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
2023-11-10 11:22 [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c Florian Weimer
@ 2023-11-29 15:27 ` Szabolcs Nagy
2023-11-29 15:31 ` Richard Earnshaw
1 sibling, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2023-11-29 15:27 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
The 11/10/2023 12:22, Florian Weimer wrote:
> This test looks like it intends to pass a small struct argument
> through both a non-variadic and variadic argument, but due to
> the typo, it does not achieve that.
>
> gcc/testsuite/
>
> * gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named.
FWIW, this looks good to me.
(but i cannot approve patches)
>
> ---
> gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> index 906ccebf616..edc35db2f6e 100644
> --- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> +++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> @@ -16,6 +16,6 @@ void unnamed (int, ...);
>
> void foo ()
> {
> - name (0, aaaa);
> + named (0, aaaa);
> unnamed (0, aaaa);
> }
>
> base-commit: 5f6c5fe078c45bc32c8d21da6b14c27c0ed7be6e
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
2023-11-10 11:22 [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c Florian Weimer
2023-11-29 15:27 ` Szabolcs Nagy
@ 2023-11-29 15:31 ` Richard Earnshaw
1 sibling, 0 replies; 3+ messages in thread
From: Richard Earnshaw @ 2023-11-29 15:31 UTC (permalink / raw)
To: Florian Weimer, gcc-patches
On 10/11/2023 11:22, Florian Weimer wrote:
> This test looks like it intends to pass a small struct argument
> through both a non-variadic and variadic argument, but due to
> the typo, it does not achieve that.
>
> gcc/testsuite/
>
> * gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named.
>
> ---
> gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> index 906ccebf616..edc35db2f6e 100644
> --- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> +++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c
> @@ -16,6 +16,6 @@ void unnamed (int, ...);
>
> void foo ()
> {
> - name (0, aaaa);
> + named (0, aaaa);
> unnamed (0, aaaa);
> }
>
> base-commit: 5f6c5fe078c45bc32c8d21da6b14c27c0ed7be6e
>
OK.
R.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-29 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 11:22 [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c Florian Weimer
2023-11-29 15:27 ` Szabolcs Nagy
2023-11-29 15:31 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).