From: Thomas Schwinge <thomas@codesourcery.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: <gcc-patches@gcc.gnu.org>, Gaius Mulley <gaiusmod2@gmail.com>,
Iain Sandoe <iain@sandoe.co.uk>,
Iain Sandoe <iains.gcc@gmail.com>
Subject: Re: [COMMITTED] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp
Date: Mon, 30 Jan 2023 16:27:38 +0100 [thread overview]
Message-ID: <87sffsjb4l.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <yddo7qgqhno.fsf@CeBiTec.Uni-Bielefeld.DE>
Hi!
On 2023-01-30T14:24:43+0100, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
> Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the
> non-default multilib, e.g.
>
> FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation, {additional_flags= -O0 -g -Werror=return-type } timeout=10
> UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution, {additional_flags= -O0 -g -Werror=return-type } timeout=10
> FAIL: gm2/case/pass/testcase1.mod, -O0 -g -Werror=return-type
> [...]
> cc1gm2: warning: '-Werror=' argument '-Werror=return-type' is not valid for Modula-2
>
> I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64.
ACK.
> I could trace this to
> gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly
> restoring TORTURE_OPTIONS.
>
> Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Installed on
> trunk.
ACK, thanks.
And note that this is independent of (or: complements) Iain's
commit r13-5473-gfe4608efc15b881ac908a3f90d7322736495ae72
"Modula-2: Claim Wreturn-type in lang.opt",
<https://inbox.sourceware.org/gcc-patches/20230128132353.77631-1-iain@sandoe.co.uk>,
which remains necessary for:
'gm2/warnings/returntype/pass/Termbase.mod',
'gm2/warnings/returntype/pass/goodreturn.mod',
'gm2/warnings/returntype/pass/keypressedsimple.mod'.
Grüße
Thomas
> 2023-01-30 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> gcc/testsuite:
> * gm2/warnings/returntype/fail/warnings-returntype-fail.exp: Save,
> restore TORTURE_OPTIONS.
>
> diff --git a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
> --- a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
> +++ b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp
> @@ -28,6 +28,8 @@ load_lib gm2-torture.exp
> gm2_init_pim "${srcdir}/gm2/warnings/returntype/fail"
>
> global TORTURE_OPTIONS
> +
> +set old_options $TORTURE_OPTIONS
> set TORTURE_OPTIONS { { -O0 -g -Werror=return-type } }
>
> foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] {
> @@ -38,3 +40,5 @@ foreach testcase [lsort [glob -nocomplai
>
> gm2-torture-fail $testcase
> }
> +
> +set TORTURE_OPTIONS $old_options
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2023-01-30 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:24 Rainer Orth
2023-01-30 15:27 ` Thomas Schwinge [this message]
2023-01-30 15:37 ` Rainer Orth
2023-01-30 18:44 ` Gaius Mulley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sffsjb4l.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gaiusmod2@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=iains.gcc@gmail.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).