From: Gaius Mulley <gaiusmod2@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] 3/19 modula2 front end: gm2 driver files.
Date: Mon, 21 Nov 2022 17:42:29 +0000 [thread overview]
Message-ID: <87sficxkze.fsf@debian> (raw)
In-Reply-To: <CAFiYyc1PyQdXq+6tDm7gCrjQuqOj7nxxW5Bvf5WPEOoS9VtjQg@mail.gmail.com> (Richard Biener's message of "Fri, 18 Nov 2022 11:21:49 +0100")
Richard Biener <richard.guenther@gmail.com> writes:
[snip]
> It feels like most of the above would usually be handled via lang specific
> specs rather than open-coded in the driver? Is there a specific reason you
> opted for explicit handling here?
The last time submitting the patches I perhaps went overboard using
lang-specs - and so tried to adopt the style from C++/fortran this time
around. I'm happy to utilize lang-specs to reduce the driver code though.
> Otherwise the patch looks generally OK, the string builds using strcat & friends
> looks like it neither takes advantage of how obstacks can be used there nor
> that we're now C++ and could use std::string - but that's a matter of taste and
> no objection.
ok thanks!
regards,
Gaius
prev parent reply other threads:[~2022-11-21 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 15:31 Gaius Mulley
2022-11-18 10:21 ` Richard Biener
2022-11-21 17:42 ` Gaius Mulley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sficxkze.fsf@debian \
--to=gaiusmod2@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).