From: Gaius Mulley <gaiusmod2@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] modula2/108462 - duplicate install of static modula2 target libs
Date: Tue, 31 Jan 2023 13:16:02 +0000 [thread overview]
Message-ID: <87wn52etf1.fsf@debian> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2301311046540.6551@jbgna.fhfr.qr> (Richard Biener's message of "Tue, 31 Jan 2023 10:46:58 +0000 (UTC)")
Richard Biener <rguenther@suse.de> writes:
> On Mon, 23 Jan 2023, Richard Biener wrote:
>
>> The following addresses the fact that libgm2 installs static libraries
>> into two places, one performed by
>>
>> toolexeclib_LTLIBRARIES = libm2cor.la
>>
>> and one performed as part of the install-data-local rule to a
>> m2/m2cor subdirectory alongside Modula-2 .def and .mod files.
>>
>> This patch opts to keep the copy installed by libtool and removes
>> the extra installs in the install-data-local rules.
>>
>> I've built and installed both with and without
>> --enable-version-specific-runtime-libs and compiled and linked
>> a Modula-2 testcase with the installed compiler with the two
>> multilibs and with and without static successfully.
>>
>> OK for trunk?
>
> Ping.
yes sure, LGTM
A heads up that I've just renamed the gcc/m2/gm2-libs-pim directory to
gcc/m2/gm2-libs-log for consistency. I've just tried the patch (post
rename changes) and the patch builds and installs fine (non bootstrap
test build though),
regards,
Gaius
next prev parent reply other threads:[~2023-01-31 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 10:46 Richard Biener
2023-01-31 13:16 ` Gaius Mulley [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-23 10:50 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn52etf1.fsf@debian \
--to=gaiusmod2@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).