public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Neumann <neumann@in.tum.de>
To: David Edelsohn <dje.gcc@gmail.com>, Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Avoid depending on destructor order
Date: Fri, 23 Sep 2022 15:38:37 +0200	[thread overview]
Message-ID: <88e489d8-4248-75de-6e8e-af6f152da61b@in.tum.de> (raw)
In-Reply-To: <CAGWvnymbagbALAbn9YV3bjCn8xucwzYHNGtdzU58o-eVd_nyKg@mail.gmail.com>

> This patch broke bootstrap on AIX and probably other targets.
> 
> #ifdef ATOMIC_FDE_FAST_PATH
> #include "unwind-dw2-btree.h"
> 
> static struct btree registered_frames;
> static bool in_shutdown;
> ...
> #else
> 
> in_shutdown only is defined for ATOMIC_FDE_FAST_PATH but used in code / 
> asserts not protected by that macro.
> 
>    gcc_assert (in_shutdown || ob);
>    return (void *) ob;
> }

I am sorry for that, I did not consider that my test machines all use 
the fast path.

I think the problem can be fixed by the trivial patch below, I will 
commit that after I have tested builds both with and without fast path.

Best

Thomas


diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c
index d237179f4ea..d6e347c5481 100644
--- a/libgcc/unwind-dw2-fde.c
+++ b/libgcc/unwind-dw2-fde.c
@@ -67,6 +67,8 @@ static void
  init_object (struct object *ob);

  #else
+/* Without fast path frame lookup must always succeed */
+static const bool in_shutdown = false;

  /* The unseen_objects list contains objects that have been registered
     but not yet categorized in any way.  The seen_objects list has had

  reply	other threads:[~2022-09-23 13:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 13:25 David Edelsohn
2022-09-23 13:38 ` Thomas Neumann [this message]
2022-09-23 14:01   ` David Edelsohn
2022-09-23 14:12     ` Thomas Neumann
2022-09-23 14:30       ` David Edelsohn
2022-09-25  6:29         ` Iain Sandoe
2022-09-25 15:29           ` Jeff Law
2022-09-26  7:55             ` Rainer Orth
2022-09-27  0:17       ` Jason Merrill
2022-09-23 14:11   ` David Edelsohn
  -- strict thread matches above, loose matches on Subject: below --
2022-09-19 16:20 Thomas Neumann
2022-09-22 22:22 ` Jason Merrill
2022-09-26 11:46 ` Claudiu Zissulescu Ianculescu
2022-09-26 11:49   ` Thomas Neumann
2022-09-26 11:50     ` Claudiu Zissulescu Ianculescu
2022-09-26 12:53     ` Iain Sandoe
2022-09-26 13:14       ` Thomas Neumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88e489d8-4248-75de-6e8e-af6f152da61b@in.tum.de \
    --to=neumann@in.tum.de \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).