Re: [PATCH] testsuite, x86: Handle a broken assembler.

Re: [PATCH] testsuite, x86: Handle a broken assembler.

[FX Coudert]

Hi,

I’d like to ping that patch from Iain Sandoe. It would clear up a number of failures in the darwin testsuite.

Thanks,
FX



> --- 8< ---
> 
> Earlier assembler support for complex fp16 on x86_64 Darin is broken. This
> adds an additional test to the existing target-supports that fails for the
> broken assemblers but works for the newer, fixed, ones.
> 
> gcc/testsuite/ChangeLog:
> 
> * lib/target-supports.exp: Test an asm line that fails on broken
> Darwin assembler versions.
> 
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
> ---
> gcc/testsuite/lib/target-supports.exp | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> index f0b692a2e19..61ab063afbe 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -10062,6 +10062,7 @@ proc check_effective_target_avx512fp16 { } {
> void foo (void)
> {
> asm volatile ("vmovw %edi, %xmm0");
> + asm volatile ("vfcmulcph %xmm1, %xmm2, %xmm3{%k1}");
> }
> } "-O2 -mavx512fp16" ]
> }
> -- 
> 2.39.2 (Apple Git-143)

Re: [PATCH] testsuite, x86: Handle a broken assembler.

[Richard Biener]

On Mon, Nov 27, 2023 at 9:11 AM FX Coudert <fxcoudert@gmail.com> wrote:
>
> Hi,
>
> I’d like to ping that patch from Iain Sandoe. It would clear up a number of failures in the darwin testsuite.

OK.

> Thanks,
> FX
>
>
>
> > --- 8< ---
> >
> > Earlier assembler support for complex fp16 on x86_64 Darin is broken. This
> > adds an additional test to the existing target-supports that fails for the
> > broken assemblers but works for the newer, fixed, ones.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * lib/target-supports.exp: Test an asm line that fails on broken
> > Darwin assembler versions.
> >
> > Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
> > ---
> > gcc/testsuite/lib/target-supports.exp | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> > index f0b692a2e19..61ab063afbe 100644
> > --- a/gcc/testsuite/lib/target-supports.exp
> > +++ b/gcc/testsuite/lib/target-supports.exp
> > @@ -10062,6 +10062,7 @@ proc check_effective_target_avx512fp16 { } {
> > void foo (void)
> > {
> > asm volatile ("vmovw %edi, %xmm0");
> > + asm volatile ("vfcmulcph %xmm1, %xmm2, %xmm3{%k1}");
> > }
> > } "-O2 -mavx512fp16" ]
> > }
> > --
> > 2.39.2 (Apple Git-143)

Re: [PATCH] testsuite, x86: Handle a broken assembler.

[FX Coudert]

Thanks Richard,
Pushed as https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d65eb8a6bbeae7533dd41cb307b427f3f8585d9b

FX

[PATCH] testsuite, x86: Handle a broken assembler.

[Iain Sandoe]

Tested on x86_64-darwin and x86_64-linux,
OK for trunk?
thanks
Iain

--- 8< ---

Earlier assembler support for complex fp16 on x86_64 Darin is broken. This
adds an additional test to the existing target-supports that fails for the
broken assemblers but works for the newer, fixed, ones.

gcc/testsuite/ChangeLog:

	* lib/target-supports.exp: Test an asm line that fails on broken
	Darwin assembler versions.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
---
 gcc/testsuite/lib/target-supports.exp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index f0b692a2e19..61ab063afbe 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -10062,6 +10062,7 @@ proc check_effective_target_avx512fp16 { } {
 	void foo (void)
 	{
 	  asm volatile ("vmovw %edi, %xmm0");
+	  asm volatile ("vfcmulcph %xmm1, %xmm2, %xmm3{%k1}");
 	}
     } "-O2 -mavx512fp16" ]
 }
-- 
2.39.2 (Apple Git-143)