[PATCH] Testsuite, i386: Fix test by passing -march

[PATCH] Testsuite, i386: Fix test by passing -march

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi,

The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.

OK to push?

FX


[-- Attachment #2: 0001-Testsuite-i386-Fix-test-by-passing-march.patch --]
[-- Type: application/octet-stream, Size: 979 bytes --]

From 5c7bbb0fcd70376d3895716d0ee33291bf4d8aff Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 12:50:01 +0100
Subject: [PATCH] Testsuite, i386: Fix test by passing -march

The test currently fails on Darwin, where the default arch is core2.

gcc/testsuite/ChangeLog:

	PR target/112287
	* gcc.target/i386/pr111698.c: Pass -march=sandybridge.
---
 gcc/testsuite/gcc.target/i386/pr111698.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/i386/pr111698.c b/gcc/testsuite/gcc.target/i386/pr111698.c
index 2da6be531a2..037000716f1 100644
--- a/gcc/testsuite/gcc.target/i386/pr111698.c
+++ b/gcc/testsuite/gcc.target/i386/pr111698.c
@@ -1,5 +1,5 @@
 /* PR target/111698 */
-/* { dg-options "-O2 -masm=att" } */
+/* { dg-options "-O2 -masm=att -march=sandybridge" } */
 /* { dg-final { scan-assembler-not "testl" } }  */
 
 int m;
-- 
2.39.3 (Apple Git-145)

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Uros Bizjak]

On Mon, Oct 30, 2023 at 12:53 PM FX Coudert <fxcoudert@gmail.com> wrote:
>
> Hi,
>
> The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
>
> OK to push?

OK.

Thanks,
Uros.

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Iain Sandoe]

> On 30 Oct 2023, at 11:53, FX Coudert <fxcoudert@gmail.com> wrote:

> The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
> 
> OK to push?

Fine from a Darwin perspective, 
we could also make it ...
dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
… if that is deemed less invasive.

Iain

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Andrew Pinski]

On Mon, Oct 30, 2023 at 5:05 AM Iain Sandoe <iain@sandoe.co.uk> wrote:
>
>
>
> > On 30 Oct 2023, at 11:53, FX Coudert <fxcoudert@gmail.com> wrote:
>
> > The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> > Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
> >
> > OK to push?
>
> Fine from a Darwin perspective,
> we could also make it ...
> dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
> … if that is deemed less invasive.

Well It can fail on x86_64-linux-gnu too if GCC was configured with
--with-arch=core2 for an example.
So having it, in this case, not being darwin specific would be
beneficial for all x86_64/i?86 targets.

Thanks,
Andrew

>
> Iain
>
>

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[FX Coudert]

> Well It can fail on x86_64-linux-gnu too if GCC was configured with
> --with-arch=core2 for an example.
> So having it, in this case, not being darwin specific would be
> beneficial for all x86_64/i?86 targets.

I pushed it as-is, meaning it will indeed apply to all x86_64/i?86 targets.

FX