From: chenglulu <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v1 1/2] LoongArch: Switch loongarch-def from C to C++ to make it possible.
Date: Tue, 5 Dec 2023 10:28:44 +0800 [thread overview]
Message-ID: <8a491f51-0d50-4db0-e0ca-1fef40783c3e@loongson.cn> (raw)
In-Reply-To: <277055d68e16fb763e52faf646ec868c36281be7.camel@xry111.site>
在 2023/12/2 下午9:41, Xi Ruoyao 写道:
> On Sat, 2023-12-02 at 20:44 +0800, chenglulu wrote:
>>>> @@ -657,12 +658,18 @@ abi_str (struct loongarch_abi abi)
>>>> strlen (loongarch_abi_base_strings[abi.base]));
>>>> else
>>>> {
>>>> + /* This situation has not yet occurred, so in order to avoid
>>>> the
>>>> + -Warray-bounds warning during C++ syntax checking, this part
>>>> + of the code is commented first.*/
>>>> + /*
>>> Just put a "gcc_unreachable ();" here?
>> Um, I just thought that the code can't go here, I will add a prompt
>> message here.:-(
> If I read the code correctly, this is indeed unreachable so we can just
> put gcc_unreachable() here. But maybe I'm wrong.
>
I agree that if it runs this far, it's a problem with the code design.
In addition,I've sorted out the patches to remove the unnecessary guards.,
and I will send the v2 version of the patch immediately.
next prev parent reply other threads:[~2023-12-05 2:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 8:14 [PATCH v1 0/2] Delete ISA_BASE_LA64V110 related definitions Lulu Cheng
2023-12-02 8:14 ` [PATCH v1 1/2] LoongArch: Switch loongarch-def from C to C++ to make it possible Lulu Cheng
2023-12-02 10:15 ` Xi Ruoyao
2023-12-02 12:44 ` chenglulu
2023-12-02 13:41 ` Xi Ruoyao
2023-12-05 2:28 ` chenglulu [this message]
2023-12-02 8:14 ` [PATCH v1 2/2] LoongArch: Remove the definition of ISA_BASE_LA64V110 from the code Lulu Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a491f51-0d50-4db0-e0ca-1fef40783c3e@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).