public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: gcc-patches@gcc.gnu.org, Martin Jambor <mjambor@suse.cz>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jan Hubicka <jh@suse.cz>
Subject: Re: [PATCH] ipa: Self-DCE of uses of removed call LHSs (PR 108007)
Date: Fri, 12 May 2023 21:21:44 +0200	[thread overview]
Message-ID: <9115858A-7830-4184-B16D-90314DF9A60F@gmail.com> (raw)
In-Reply-To: <ri6sfc1g1lx.fsf@suse.cz>

On 12 May 2023 14:45:14 CEST, Martin Jambor <mjambor@suse.cz> wrote:

>gcc/ChangeLog:
>
>2023-05-11  Martin Jambor  <mjambor@suse.cz>
>
>	PR ipa/108007
>	* cgraph.h (cgraph_edge): Add a parameter to
>	redirect_call_stmt_to_callee.
>	* ipa-param-manipulation.h (ipa_param_adjustments): Added a
>	parameter to modify_call.
>	* cgraph.cc (cgraph_edge::redirect_call_stmt_to_callee): New
>	parameter killed_ssas, pass it to padjs->modify_call.
>	* ipa-param-manipulation.cc (purge_transitive_uses): New function.
>	(ipa_param_adjustments::modify_call): New parameter killed_ssas.
>	Instead of substitutin uses, invoke purge_transitive_uses.  If
>	hash of killed SSAs has not been provided, create a temporary one
>	and release SSAs that have been added to it.
>	* tree-inline.cc (redirect_all_calls): Create
>	id->killed_new_ssa_names earlier, pass it to edge redirection,
>	adjust a comment.
>	(copy_body): Release SSAs in id->killed_new_ssa_names.

Nit: Please use present tense in the ChangeLog.
s/Added/Add/
And there is a trailing 'g' missing in substitutin
thanks,

  reply	other threads:[~2023-05-12 19:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 12:45 Martin Jambor
2023-05-12 19:21 ` Bernhard Reutner-Fischer [this message]
2023-06-13 15:11 ` Martin Jambor
2023-06-15  9:20   ` Bernhard Reutner-Fischer
2023-09-01 13:32 ` Martin Jambor
2023-09-19 11:36   ` Martin Jambor
2023-09-25  8:52     ` Jan Hubicka
2023-10-03 17:07       ` Martin Jambor
2023-10-05  0:08         ` Maciej W. Rozycki
2023-10-05  0:09           ` Andrew Pinski
2024-01-16 12:39 Martin Jambor
2024-01-22 17:21 ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9115858A-7830-4184-B16D-90314DF9A60F@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jh@suse.cz \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).