From: Jeff Law <jeffreyalaw@gmail.com>
To: Kito Cheng <kito.cheng@gmail.com>, Fei Gao <gaofei@eswincomputing.com>
Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, zengxiao@eswincomputing.com
Subject: Re: [PATCH 1/4] [RISC-V] prefer Zicond primitive semantics to SFB
Date: Mon, 27 Nov 2023 22:03:16 -0700 [thread overview]
Message-ID: <91d11f82-485e-458a-ab23-17ce70bb40d5@gmail.com> (raw)
In-Reply-To: <CA+yXCZDxJjxGMioMLTTVBPyRbL-WKjbubH7JC8Qi_gdvzVFt1Q@mail.gmail.com>
On 11/27/23 20:09, Kito Cheng wrote:
> Personally I don't like to play with the pattern order to tweak the
> code gen since it kinda introduces implicit relation/rule here, but I
> guess the only way to prevent that is to duplicate the pattern for SFB
> again, which is not an ideal solution...
I won't object to this patch, but I don't really like it either.
This patch highlights that the SFB code is not well integrated with the
rest of the conditional move support.
Jeff
next prev parent reply other threads:[~2023-11-28 5:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 2:32 Fei Gao
2023-11-28 2:32 ` [PATCH 2/4] [ifcvt] optimize x=c ? (y op z) : y by RISC-V Zicond like insns Fei Gao
2023-11-29 5:26 ` Jeff Law
2023-11-29 11:09 ` Fei Gao
2023-12-05 8:36 ` Fei Gao
2023-11-28 2:32 ` [PATCH 3/4] [ifcvt] optimize x=c ? (y op const_int) " Fei Gao
2023-11-28 2:32 ` [PATCH 4/4] [V2] [ifcvt] prefer SFB to Zicond for x=c ? (y op CONST) : y Fei Gao
2023-11-28 5:00 ` Jeff Law
2023-11-28 3:09 ` [PATCH 1/4] [RISC-V] prefer Zicond primitive semantics to SFB Kito Cheng
2023-11-28 5:03 ` Jeff Law [this message]
2023-12-04 7:01 ` Fei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d11f82-485e-458a-ab23-17ce70bb40d5@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gaofei@eswincomputing.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=zengxiao@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).