* [COMMITTED] PR tree-optimization/106687 - Return the correct relation
@ 2022-08-23 1:06 Andrew MacLeod
0 siblings, 0 replies; only message in thread
From: Andrew MacLeod @ 2022-08-23 1:06 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
With an input condition of op1 > op2, and evaluating the unsigned
expression:
LHS = op1 - op2
range-ops was returning LHS < op1 , which is incorrect as op2 could be
zero. This patch adjusts it to return LHS <= op1.
Bootstrapped on x86_64-pc-linux-gnu with no regressions. Pushed.
Andrew
[-- Attachment #2: 687.diff --]
[-- Type: text/x-patch, Size: 1611 bytes --]
commit de6d9e0b3d5c08896cbf047b299fc7f8d1e42be7
Author: Andrew MacLeod <amacleod@redhat.com>
Date: Mon Aug 22 15:40:48 2022 -0400
Return the correct relation
With an input condition of op1 > op2, and evaluating the unsigned expression:
LHS = op1 - op2
range-ops was returning LHS < op1 , which is incorrect as op2 coould be
zero. This patch adjusts it to return LHS <= op1.
PR tree-optimization/106687
gcc/
* range-op.cc (operator_minus::lhs_op1_relation): Return VREL_LE
for the VREL_GT case as well.
gcc/testsuite/
* g++.dg/pr106687.C: New.
diff --git a/gcc/range-op.cc b/gcc/range-op.cc
index dfdd971c90a..806edf1012e 100644
--- a/gcc/range-op.cc
+++ b/gcc/range-op.cc
@@ -1378,7 +1378,6 @@ operator_minus::lhs_op1_relation (const irange &, const irange &op1,
switch (rel)
{
case VREL_GT:
- return VREL_LT;
case VREL_GE:
return VREL_LE;
default:
diff --git a/gcc/testsuite/g++.dg/pr106687.C b/gcc/testsuite/g++.dg/pr106687.C
new file mode 100644
index 00000000000..75ac81c216c
--- /dev/null
+++ b/gcc/testsuite/g++.dg/pr106687.C
@@ -0,0 +1,22 @@
+// { dg-do run }
+// { dg-options "-O2" }
+
+bool var_0 = (bool)0;
+unsigned int var_7 = 42;
+char var_215;
+
+int main() {
+ unsigned b = var_0;
+ unsigned p2 = var_7;
+ unsigned *tp;
+ if (b < p2)
+ tp = &p2;
+ else
+ tp = &b;
+ unsigned tt = *tp;
+ unsigned t = tt ^ (var_7 - var_0);
+ var_215 = t ? t : 42;
+ if (var_215 != 42)
+ __builtin_abort();
+ return 0;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-23 1:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 1:06 [COMMITTED] PR tree-optimization/106687 - Return the correct relation Andrew MacLeod
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).