* [PATCH] Fix some comment nits
@ 2024-04-16 7:42 Jakub Jelinek
2024-04-16 7:47 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-04-16 7:42 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
Hi!
While studying the TYPE_CANONICAL/TYPE_STRUCTURAL_EQUALITY_P stuff,
I've noticed some nits in comments, the following patch fixes them.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
2024-04-16 Jakub Jelinek <jakub@redhat.com>
* tree.cc (array_type_nelts): Ensure 2 spaces after . in comment
instead of just one.
(build_variant_type_copy): Likewise.
(tree_check_failed): Likewise.
(build_atomic_base): Likewise.
* ipa-free-lang-data.cc (fld_incomplete_type_of): Use an indefinite
article rather than a.
--- gcc/tree.cc.jj 2024-04-15 14:25:21.721813546 +0200
+++ gcc/tree.cc 2024-04-15 17:49:25.923935286 +0200
@@ -3689,7 +3689,7 @@ int_byte_position (const_tree field)
}
\f
/* Return, as a tree node, the number of elements for TYPE (which is an
- ARRAY_TYPE) minus one. This counts only elements of the top array. */
+ ARRAY_TYPE) minus one. This counts only elements of the top array. */
tree
array_type_nelts (const_tree type)
@@ -5757,7 +5757,7 @@ build_variant_type_copy (tree type MEM_S
t = build_distinct_type_copy (type PASS_MEM_STAT);
/* Since we're building a variant, assume that it is a non-semantic
- variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */
+ variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */
TYPE_CANONICAL (t) = TYPE_CANONICAL (type);
/* Type variants have no alias set defined. */
TYPE_ALIAS_SET (t) = -1;
@@ -8915,7 +8915,7 @@ get_file_function_name (const char *type
#if defined ENABLE_TREE_CHECKING && (GCC_VERSION >= 2007)
/* Complain that the tree code of NODE does not match the expected 0
- terminated list of trailing codes. The trailing code list can be
+ terminated list of trailing codes. The trailing code list can be
empty, for a more vague error message. FILE, LINE, and FUNCTION
are of the caller. */
@@ -9332,7 +9332,7 @@ make_or_reuse_accum_type (unsigned size,
/* Create an atomic variant node for TYPE. This routine is called
during initialization of data types to create the 5 basic atomic
- types. The generic build_variant_type function requires these to
+ types. The generic build_variant_type function requires these to
already be set up in order to function properly, so cannot be
called from there. If ALIGN is non-zero, then ensure alignment is
overridden to this value. */
--- gcc/ipa-free-lang-data.cc.jj 2024-04-15 14:25:21.668814259 +0200
+++ gcc/ipa-free-lang-data.cc 2024-04-15 17:49:47.303647823 +0200
@@ -234,7 +234,7 @@ fld_decl_context (tree ctx)
return ctx;
}
-/* For T being aggregate type try to turn it into a incomplete variant.
+/* For T being aggregate type try to turn it into an incomplete variant.
Return T if no simplification is possible. */
static tree
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix some comment nits
2024-04-16 7:42 [PATCH] Fix some comment nits Jakub Jelinek
@ 2024-04-16 7:47 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-04-16 7:47 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Tue, 16 Apr 2024, Jakub Jelinek wrote:
> Hi!
>
> While studying the TYPE_CANONICAL/TYPE_STRUCTURAL_EQUALITY_P stuff,
> I've noticed some nits in comments, the following patch fixes them.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK (IMO obvious).
Richard.
> 2024-04-16 Jakub Jelinek <jakub@redhat.com>
>
> * tree.cc (array_type_nelts): Ensure 2 spaces after . in comment
> instead of just one.
> (build_variant_type_copy): Likewise.
> (tree_check_failed): Likewise.
> (build_atomic_base): Likewise.
> * ipa-free-lang-data.cc (fld_incomplete_type_of): Use an indefinite
> article rather than a.
>
> --- gcc/tree.cc.jj 2024-04-15 14:25:21.721813546 +0200
> +++ gcc/tree.cc 2024-04-15 17:49:25.923935286 +0200
> @@ -3689,7 +3689,7 @@ int_byte_position (const_tree field)
> }
> \f
> /* Return, as a tree node, the number of elements for TYPE (which is an
> - ARRAY_TYPE) minus one. This counts only elements of the top array. */
> + ARRAY_TYPE) minus one. This counts only elements of the top array. */
>
> tree
> array_type_nelts (const_tree type)
> @@ -5757,7 +5757,7 @@ build_variant_type_copy (tree type MEM_S
> t = build_distinct_type_copy (type PASS_MEM_STAT);
>
> /* Since we're building a variant, assume that it is a non-semantic
> - variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */
> + variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */
> TYPE_CANONICAL (t) = TYPE_CANONICAL (type);
> /* Type variants have no alias set defined. */
> TYPE_ALIAS_SET (t) = -1;
> @@ -8915,7 +8915,7 @@ get_file_function_name (const char *type
> #if defined ENABLE_TREE_CHECKING && (GCC_VERSION >= 2007)
>
> /* Complain that the tree code of NODE does not match the expected 0
> - terminated list of trailing codes. The trailing code list can be
> + terminated list of trailing codes. The trailing code list can be
> empty, for a more vague error message. FILE, LINE, and FUNCTION
> are of the caller. */
>
> @@ -9332,7 +9332,7 @@ make_or_reuse_accum_type (unsigned size,
>
> /* Create an atomic variant node for TYPE. This routine is called
> during initialization of data types to create the 5 basic atomic
> - types. The generic build_variant_type function requires these to
> + types. The generic build_variant_type function requires these to
> already be set up in order to function properly, so cannot be
> called from there. If ALIGN is non-zero, then ensure alignment is
> overridden to this value. */
> --- gcc/ipa-free-lang-data.cc.jj 2024-04-15 14:25:21.668814259 +0200
> +++ gcc/ipa-free-lang-data.cc 2024-04-15 17:49:47.303647823 +0200
> @@ -234,7 +234,7 @@ fld_decl_context (tree ctx)
> return ctx;
> }
>
> -/* For T being aggregate type try to turn it into a incomplete variant.
> +/* For T being aggregate type try to turn it into an incomplete variant.
> Return T if no simplification is possible. */
>
> static tree
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-16 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16 7:42 [PATCH] Fix some comment nits Jakub Jelinek
2024-04-16 7:47 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).