From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>,
Lehua Ding <lehua.ding@rivai.ai>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: fix the condition bug in tsvc s176
Date: Fri, 9 Jun 2023 07:29:43 -0600 [thread overview]
Message-ID: <9b66e5df-adeb-c6f3-8ffb-f3a9faf5b0c9@gmail.com> (raw)
In-Reply-To: <CAFiYyc0Y4Q9YLoqwEQyL8hynMHDJ0wVz6V_dGXnnDwHdRwJaRg@mail.gmail.com>
On 6/9/23 05:56, Richard Biener via Gcc-patches wrote:
> On Fri, Jun 9, 2023 at 11:58 AM Lehua Ding <lehua.ding@rivai.ai> wrote:
>>
>>> It's odd that the checksum doesn't depend on the number of iterations done ...
>>
>> This is because the difference between the calculated result (32063.902344) and
>> the expected result (32000.000000) is small. The current check is that the result
>> is considered correct as long as the `value/expected` ratio is between 0.99f and
>> 1.01f.
>
> Oh, I see ...
>
>> I'm not sure if this check is enough, but I should also update the expected
>> result to 32063.902344 (the same without vectorized).
>
> OK.
>
>> Best,
>> Lehua
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.dg/vect/tsvc/tsvc.h:
>> * gcc.dg/vect/tsvc/vect-tsvc-s176.c:
I stitched together appropriate ChangeLog entries and pushed this to the
trunk (I don't think Lehua has write access).
jeff
next prev parent reply other threads:[~2023-06-09 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:57 Lehua Ding
2023-06-09 11:56 ` Richard Biener
2023-06-09 13:29 ` Jeff Law [this message]
2023-06-09 13:49 ` Lehua Ding
-- strict thread matches above, loose matches on Subject: below --
2023-06-08 11:23 Lehua Ding
2023-06-09 8:58 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b66e5df-adeb-c6f3-8ffb-f3a9faf5b0c9@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lehua.ding@rivai.ai \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).