From: "Martin Liška" <mliska@suse.cz>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file
Date: Tue, 24 Jan 2023 14:34:31 +0100 [thread overview]
Message-ID: <9cfb9de3-1b7a-60e2-70ba-ac3b534e2871@suse.cz> (raw)
In-Reply-To: <3cf31374-0496-3119-7775-0c22bc03cb38@suse.cz>
PING^1
On 1/10/23 16:10, Martin Liška wrote:
> On 1/6/23 14:21, David Malcolm wrote:
>> On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote:
>>> Patch can bootstrap on x86_64-linux-gnu and survives regression
>>> tests.
>>
>> Thanks for the patch.
>>
>> I noticed that you marked PR 108307 as a dup of this, which covers
>> -fdiagnostics-format=sarif-file (and a .S file as input).
>>
>> The patch doesn't add any test coverage (for either of the diagnostic
>> formats).
>>
>> If we try to emit a diagnostic and base_file_name is NULL, and the user
>> requested one of -fdiagnostics-format={json,sarif}-file, where do the
>> diagnostics go? Where should they go?
>
> Hey.
>
> I've done a new version of the patch where I utilize x_main_input_basename.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
next prev parent reply other threads:[~2023-01-24 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:33 Martin Liška
2023-01-06 13:21 ` David Malcolm
2023-01-10 15:10 ` Martin Liška
2023-01-24 13:34 ` Martin Liška [this message]
2023-02-01 13:13 ` Martin Liška
2023-02-17 14:52 ` Martin Liška
2023-02-27 9:49 ` Martin Liška
2023-03-16 10:05 ` Martin Liška
2023-03-16 14:45 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cfb9de3-1b7a-60e2-70ba-ac3b534e2871@suse.cz \
--to=mliska@suse.cz \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).