Re: [PATCH] diagnostics: fix crash with -fdiagnostics-format=json-file

["Martin Liška" <mliska@suse.cz>]

PING^2

On 1/24/23 14:34, Martin Liška wrote:
> PING^1
> 
> On 1/10/23 16:10, Martin Liška wrote:
>> On 1/6/23 14:21, David Malcolm wrote:
>>> On Fri, 2023-01-06 at 12:33 +0100, Martin Liška wrote:
>>>> Patch can bootstrap on x86_64-linux-gnu and survives regression
>>>> tests.
>>>
>>> Thanks for the patch.
>>>
>>> I noticed that you marked PR 108307 as a dup of this, which covers
>>> -fdiagnostics-format=sarif-file (and a .S file as input).
>>>
>>> The patch doesn't add any test coverage (for either of the diagnostic
>>> formats).
>>>
>>> If we try to emit a diagnostic and base_file_name is NULL, and the user
>>> requested one of -fdiagnostics-format={json,sarif}-file, where do the
>>> diagnostics go?  Where should they go?
>>
>> Hey.
>>
>> I've done a new version of the patch where I utilize x_main_input_basename.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>> Thanks,
>> Martin
>