From: Patrick Palka <ppalka@redhat.com>
To: Nathaniel Shead <nathanieloshead@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH] c++: Fix ICE with xobj parms and maybe incomplete decl-specifiers
Date: Sun, 21 Apr 2024 22:59:00 -0400 (EDT) [thread overview]
Message-ID: <9e62be06-2554-82ad-071b-f83f4c61b7e6@idea> (raw)
In-Reply-To: <66237f1b.630a0220.ed3e.fd8b@mx.google.com>
> Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
>
> -- >8 --
>
> This fixes a null dereference issue when decl_specifiers.type is not yet
> provided.
>
> gcc/cp/ChangeLog:
>
> * parser.cc (cp_parser_parameter_declaration): Check if
> decl_specifiers.type is null.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/cpp23/explicit-obj-basic7.C: New test.
LGTM
>
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
> ---
> gcc/cp/parser.cc | 5 +++--
> gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C | 9 +++++++++
> 2 files changed, 12 insertions(+), 2 deletions(-)
> create mode 100644 gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C
>
> diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
> index 50d3ad35b61..97ee2650dc4 100644
> --- a/gcc/cp/parser.cc
> +++ b/gcc/cp/parser.cc
> @@ -25780,8 +25780,9 @@ cp_parser_parameter_declaration (cp_parser *parser,
> }
>
> if (xobj_param_p
> - && (declarator ? declarator->parameter_pack_p
> - : PACK_EXPANSION_P (decl_specifiers.type)))
> + && ((declarator && declarator->parameter_pack_p)
> + || (decl_specifiers.type
> + && PACK_EXPANSION_P (decl_specifiers.type))))
> {
> location_t xobj_param
> = make_location (decl_specifiers.locations[ds_this],
> diff --git a/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C b/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C
> new file mode 100644
> index 00000000000..a474e97fc18
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C
> @@ -0,0 +1,9 @@
> +// { dg-do compile { target c++23 } }
> +
> +// Shouldn't ICE
> +struct S {
> + void a(this long);
> + void b(this const long);
> + void c(this long unsigned);
> + void c(this signed);
> +};
> --
> 2.43.2
>
>
next prev parent reply other threads:[~2024-04-22 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 8:38 Nathaniel Shead
2024-04-22 2:59 ` Patrick Palka [this message]
2024-04-23 14:39 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e62be06-2554-82ad-071b-f83f4c61b7e6@idea \
--to=ppalka@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathanieloshead@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).