From: Jeff Law <law@redhat.com>
To: Seija Kijin <doremylover456@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libiberty: Make strstr.c in libiberty ANSI compliant
Date: Fri, 13 Nov 2020 11:53:43 -0700 [thread overview]
Message-ID: <9e7e3075-5347-ac3a-21a1-dbcd5e7a9d93@redhat.com> (raw)
In-Reply-To: <CAOfV4GfJUNVS7shv2vkFO+NE-0Ui0sdO3BgJqViXPT9qPT4HFQ@mail.gmail.com>
On 5/1/20 6:06 PM, Seija Kijin via Gcc-patches wrote:
> The original code in libiberty says "FIXME" and then says it has not been
> validated to be ANSI compliant. However, this patch changes the function to
> match implementations that ARE compliant, and such code is in the public
> domain.
>
> I ran the test results, and there are no test failures.
Thanks. This seems to be the standard "simple" strstr implementation.
There's significantly faster implementations available, but I doubt it's
worth the effort as the version in this file only gets used if there is
no system strstr.c.
I've pushed this patch to the trunk after fixing some minor formatting
issues
jeff
next prev parent reply other threads:[~2020-11-13 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 0:06 Seija Kijin
2020-11-13 18:53 ` Jeff Law [this message]
2023-03-29 15:00 ` Jakub Jelinek
2023-04-02 17:54 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e7e3075-5347-ac3a-21a1-dbcd5e7a9d93@redhat.com \
--to=law@redhat.com \
--cc=doremylover456@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).