From: Richard Guenther <richard.guenther@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Cgraph alias reorg 13/14 (disable inlining functions called once at -O0
Date: Fri, 10 Jun 2011 20:10:00 -0000 [thread overview]
Message-ID: <BANLkTikzudJRTUAKTZfLFF6VMY0-suvGQw@mail.gmail.com> (raw)
In-Reply-To: <20110610184247.GA3252@kam.mff.cuni.cz>
On Fri, Jun 10, 2011 at 8:42 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> by some mistake we enable functions called once at -O0 and it actually happens from
> time to time.
Why do it for -O1? It definitely makes debugging less reliable. I'd say do it
for -O[23s] only.
Richard.
> Bootstrapped/regtested x86_64-linux, will commit it shortly.
>
> Honza
>
> * opts.c (default_options): Enlist OPT_finline_functions_called_once.
> * common.opt (flag_inline_functions_called_once):Do not initialize to 1.
> Index: opts.c
> ===================================================================
> --- opts.c (revision 174916)
> +++ opts.c (working copy)
> @@ -486,6 +486,7 @@ static const struct default_options defa
> /* Inlining of functions reducing size is a good idea with -Os
> regardless of them being declared inline. */
> { OPT_LEVELS_3_PLUS_AND_SIZE, OPT_finline_functions, NULL, 1 },
> + { OPT_LEVELS_1_PLUS, OPT_finline_functions_called_once, NULL, 1 },
> { OPT_LEVELS_3_PLUS, OPT_funswitch_loops, NULL, 1 },
> { OPT_LEVELS_3_PLUS, OPT_fgcse_after_reload, NULL, 1 },
> { OPT_LEVELS_3_PLUS, OPT_ftree_vectorize, NULL, 1 },
> Index: common.opt
> ===================================================================
> --- common.opt (revision 174916)
> +++ common.opt (working copy)
> @@ -1233,7 +1233,7 @@ Common Report Var(flag_inline_functions)
> Integrate simple functions into their callers
>
> finline-functions-called-once
> -Common Report Var(flag_inline_functions_called_once) Init(1) Optimization
> +Common Report Var(flag_inline_functions_called_once) Optimization
> Integrate functions called once into their callers
>
> finline-limit-
>
next prev parent reply other threads:[~2011-06-10 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 18:47 Jan Hubicka
2011-06-10 20:10 ` Richard Guenther [this message]
2011-06-10 20:59 ` Jan Hubicka
2011-06-12 10:56 ` Richard Guenther
2011-06-14 15:10 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikzudJRTUAKTZfLFF6VMY0-suvGQw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).