* [pph] Rename pph_output__tree_header to respect naming convention (issue4528135)
@ 2011-06-10 2:09 Gabriel Charette
2011-06-10 2:54 ` Diego Novillo
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Charette @ 2011-06-10 2:09 UTC (permalink / raw)
To: reply, crowl, dnovillo, gcc-patches
This was probably introduced in sync with my renaming patch. Just noticed and fixed it.
There isn't the equivalent pph_input function, is that normal?
Index: pph-streamer.c
===================================================================
--- pph-streamer.c (revision 174853)
+++ pph-streamer.c (working copy)
@@ -96,7 +96,7 @@
streamer_hooks.indexable_with_decls_p = pph_indexable_with_decls_p;
streamer_hooks.unpack_value_fields = pph_unpack_value_fields;
streamer_hooks.alloc_tree = pph_alloc_tree;
- streamer_hooks.output_tree_header = pph_output_tree_header;
+ streamer_hooks.output_tree_header = pph_out_tree_header;
streamer_hooks.has_unique_integer_csts_p = true;
}
Index: pph-streamer-out.c
===================================================================
--- pph-streamer-out.c (revision 174853)
+++ pph-streamer-out.c (working copy)
@@ -838,7 +838,7 @@
OB. If EXPR does not need to be handled specially, do nothing. */
void
-pph_output_tree_header (struct output_block *ob, tree expr)
+pph_out_tree_header (struct output_block *ob, tree expr)
{
pph_stream *stream = (pph_stream *) ob->sdata;
Index: pph-streamer.h
===================================================================
--- pph-streamer.h (revision 174853)
+++ pph-streamer.h (working copy)
@@ -142,7 +142,7 @@
void pph_init_write (pph_stream *);
void pph_write_tree (struct output_block *, tree, bool ref_p);
void pph_pack_value_fields (struct bitpack_d *, tree);
-void pph_output_tree_header (struct output_block *, tree);
+void pph_out_tree_header (struct output_block *, tree);
void pph_out_chain_filtered (pph_stream *, tree, bool, enum chain_filter);
/* In name-lookup.c. */
Index: ChangeLog.pph
===================================================================
--- ChangeLog.pph (revision 174853)
+++ ChangeLog.pph (working copy)
@@ -1,3 +1,8 @@
+2011-06-09 Gabriel Charette <gchare@google.com>
+
+ * pph-streamer-out.c (pph_out_tree_header): Rename from
+ pph_output_tree_header. Update all users.
+
2011-06-08 Diego Novillo <dnovillo@google.com>
* parser.c (cp_lexer_dump_tokens): If START_TOKEN is NULL,
--
This patch is available for review at http://codereview.appspot.com/4528135
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pph] Rename pph_output__tree_header to respect naming convention (issue4528135)
2011-06-10 2:09 [pph] Rename pph_output__tree_header to respect naming convention (issue4528135) Gabriel Charette
@ 2011-06-10 2:54 ` Diego Novillo
2011-06-10 3:00 ` Diego Novillo
0 siblings, 1 reply; 3+ messages in thread
From: Diego Novillo @ 2011-06-10 2:54 UTC (permalink / raw)
To: Gabriel Charette; +Cc: reply, Lawrence Crowl, gcc-patches
On Thu, Jun 9, 2011 at 18:58, Gabriel Charette <gchare@google.com> wrote:
> This was probably introduced in sync with my renaming patch. Just noticed and fixed it.
>
> There isn't the equivalent pph_input function, is that normal?
Yeah, the bits written by the header output routine are read and used
by the alloc_tree() hook on the reading side. The tree header is used
by those special trees that need extra information to be materialized
on the reading side.
> Index: pph-streamer.c
> ===================================================================
> --- pph-streamer.c (revision 174853)
> +++ pph-streamer.c (working copy)
> @@ -96,7 +96,7 @@
> streamer_hooks.indexable_with_decls_p = pph_indexable_with_decls_p;
> streamer_hooks.unpack_value_fields = pph_unpack_value_fields;
> streamer_hooks.alloc_tree = pph_alloc_tree;
> - streamer_hooks.output_tree_header = pph_output_tree_header;
> + streamer_hooks.output_tree_header = pph_out_tree_header;
> streamer_hooks.has_unique_integer_csts_p = true;
> }
>
> Index: pph-streamer-out.c
> ===================================================================
> --- pph-streamer-out.c (revision 174853)
> +++ pph-streamer-out.c (working copy)
> @@ -838,7 +838,7 @@
> OB. If EXPR does not need to be handled specially, do nothing. */
>
> void
> -pph_output_tree_header (struct output_block *ob, tree expr)
> +pph_out_tree_header (struct output_block *ob, tree expr)
> {
> pph_stream *stream = (pph_stream *) ob->sdata;
>
> Index: pph-streamer.h
> ===================================================================
> --- pph-streamer.h (revision 174853)
> +++ pph-streamer.h (working copy)
> @@ -142,7 +142,7 @@
> void pph_init_write (pph_stream *);
> void pph_write_tree (struct output_block *, tree, bool ref_p);
> void pph_pack_value_fields (struct bitpack_d *, tree);
> -void pph_output_tree_header (struct output_block *, tree);
> +void pph_out_tree_header (struct output_block *, tree);
> void pph_out_chain_filtered (pph_stream *, tree, bool, enum chain_filter);
>
> /* In name-lookup.c. */
> Index: ChangeLog.pph
> ===================================================================
> --- ChangeLog.pph (revision 174853)
> +++ ChangeLog.pph (working copy)
> @@ -1,3 +1,8 @@
> +2011-06-09 Gabriel Charette <gchare@google.com>
> +
> + * pph-streamer-out.c (pph_out_tree_header): Rename from
> + pph_output_tree_header. Update all users.
> +
OK.
Diego.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pph] Rename pph_output__tree_header to respect naming convention (issue4528135)
2011-06-10 2:54 ` Diego Novillo
@ 2011-06-10 3:00 ` Diego Novillo
0 siblings, 0 replies; 3+ messages in thread
From: Diego Novillo @ 2011-06-10 3:00 UTC (permalink / raw)
To: Gabriel Charette; +Cc: reply, Lawrence Crowl, gcc-patches
On Thu, Jun 9, 2011 at 19:06, Diego Novillo <dnovillo@google.com> wrote:
>> +2011-06-09 Gabriel Charette <gchare@google.com>
>> +
>> + * pph-streamer-out.c (pph_out_tree_header): Rename from
>> + pph_output_tree_header. Update all users.
>> +
>
> OK.
Committed at rev. 174879.
Diego.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-10 2:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-10 2:09 [pph] Rename pph_output__tree_header to respect naming convention (issue4528135) Gabriel Charette
2011-06-10 2:54 ` Diego Novillo
2011-06-10 3:00 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).