* [PATCH] [arm] xfail fp-uint64-convert-double-* on all arm targets
@ 2023-02-17 6:20 Alexandre Oliva
2023-02-17 19:55 ` Mike Stump
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2023-02-17 6:20 UTC (permalink / raw)
To: gcc-patches
Cc: nickc, richard.earnshaw, ramana.gcc, kyrylo.tkachov, ro, mikestump
It wasn't long ago that I xfailed these tests on arm-*-eabi, but the
fail is expected on all other arm targets: even when hard float is
available, conversions between 64-bit integers and double are always
emulated on ARM, and the emulation disregards rounding modes. So,
bump the xfail to all of arm-*-*.
Regstrapped on x86_64-linux-gnu.
Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
for gcc/testsuite/ChangeLog
* gcc.dg/torture/fp-uint64-convert-double-1.c: XFAIL on all of
arm-*-*.
* gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise.
---
.../gcc.dg/torture/fp-uint64-convert-double-1.c | 2 +-
.../gcc.dg/torture/fp-uint64-convert-double-2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
index 61cfa96374631..8f437e2efb1db 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c
@@ -1,5 +1,5 @@
/* PR84407 */
-/* { dg-do run { xfail { arm-*-eabi* } } } */
+/* { dg-do run { xfail { arm-*-* } } } */
/* { dg-require-effective-target fenv } */
/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math -fexcess-precision=standard" } */
diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
index b32b28a329580..fd3f4cbfb830f 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c
@@ -1,5 +1,5 @@
/* PR84407 */
-/* { dg-do run { xfail { arm-*-eabi* } } } */
+/* { dg-do run { xfail { arm-*-* } } } */
/* { dg-require-effective-target fenv } */
/* { dg-require-effective-target hard_float } */
/* { dg-additional-options "-frounding-math" } */
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [arm] xfail fp-uint64-convert-double-* on all arm targets
2023-02-17 6:20 [PATCH] [arm] xfail fp-uint64-convert-double-* on all arm targets Alexandre Oliva
@ 2023-02-17 19:55 ` Mike Stump
0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2023-02-17 19:55 UTC (permalink / raw)
To: Alexandre Oliva
Cc: gcc-patches, nickc, richard.earnshaw, ramana.gcc, kyrylo.tkachov,
ro@cebitec.uni-bielefeld.de
On Feb 16, 2023, at 10:20 PM, Alexandre Oliva <oliva@adacore.com> wrote:
>
> It wasn't long ago that I xfailed these tests on arm-*-eabi, but the
> fail is expected on all other arm targets: even when hard float is
> available, conversions between 64-bit integers and double are always
> emulated on ARM, and the emulation disregards rounding modes. So,
> bump the xfail to all of arm-*-*.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
Ok.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 6:20 [PATCH] [arm] xfail fp-uint64-convert-double-* on all arm targets Alexandre Oliva
2023-02-17 19:55 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).