[PATCH] Testsuite, Darwin: skip PIE test

[PATCH] Testsuite, Darwin: skip PIE test

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi,

The recent commit of https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634347.html has made this test invalid. We now don’t emit __PIE__, and the test should be skipped on darwin.

Fixes the new failure on x86_64-apple-darwin21. OK to push?
FX


[-- Attachment #2: 0001-Testsuite-Darwin-skip-PIE-test.patch --]
[-- Type: application/octet-stream, Size: 871 bytes --]

From a0c557690c8d5327deda6e21f8d1deca8451a4cb Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 12:41:17 +0100
Subject: [PATCH] Testsuite, Darwin: skip PIE test

gcc/testsuite/ChangeLog:

	* gcc.dg/pie-2.c: Skip test on darwin.
---
 gcc/testsuite/gcc.dg/pie-2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.dg/pie-2.c b/gcc/testsuite/gcc.dg/pie-2.c
index 1838745a11a..0a1cc27a503 100644
--- a/gcc/testsuite/gcc.dg/pie-2.c
+++ b/gcc/testsuite/gcc.dg/pie-2.c
@@ -2,6 +2,7 @@
 /* { dg-options "-fPIE" } */
 /* { dg-require-effective-target pie } */
 /* { dg-skip-if "__PIC__ is always 1 for MIPS" { mips*-*-* } } */
+/* { dg-skip-if "__PIE__ is often not defined on darwin" { *-*-darwin* } } */
 
 #if __PIC__ != 2
 # error __PIC__ is not 2!
-- 
2.39.3 (Apple Git-145)

Re: [PATCH] Testsuite, Darwin: skip PIE test

[Iain Sandoe]

HI FX,

> On 30 Oct 2023, at 11:43, FX Coudert <fxcoudert@gmail.com> wrote:

> The recent commit of https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634347.html has made this test invalid. We now don’t emit __PIE__, and the test should be skipped on darwin.
> 
> Fixes the new failure on x86_64-apple-darwin21. OK to push?

OK, thanks,
Iain