From: Andrew Pinski <pinskia@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Joern Rennecke <joern.rennecke@embecosm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: committed [RISC-V]: Harden test scan patterns
Date: Wed, 27 Sep 2023 15:12:49 -0700 [thread overview]
Message-ID: <CA+=Sn1=NOiz4hYp1khs36a-x=zWqw1t2FYnX3pCDh7_7JBsDgg@mail.gmail.com> (raw)
In-Reply-To: <fff6634e-2c47-4df7-9e0d-c66c8c7dcab5@gmail.com>
On Wed, Sep 27, 2023 at 1:14 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 9/27/23 12:22, Joern Rennecke wrote:
> > On Wed, 27 Sept 2023 at 18:22, Jeff Law <jeffreyalaw@gmail.com> wrote:
> >
> >> It would help to describe how these patterns were under specified so
> >> that folks don't continue to make the same mistake as new tests get added.
> >
> > dg-final scan-assembler, scan-assembler-not, and scan-assembler-times
> > use a tcl regular expression (often referred to abbreviated as RE), as
> > described in https://www.tcl.tk/man/tcl8.4/TclCmd/re_syntax.html .
> >
> > If your RE is not specific enough, it can match LTO information that the
> > compiler places into its assembly output when the relevant options are
> > provided, which is common when running tests where the test harness
> > iterates over a number of optimization option combinations.
> > Note that '.' is an atom that can match any character. If you want to
> > match a dot specifically, you have to escape it with a backslash: '\.' .
> > When you are matching an instruction mnemonic, an effective way to
> > avoid matching in LTO information is to enforce matching of word start
> > (\m) and/or word end (\M) .
> > Note also that the backslash has to be quoted. If the RE is enclosed in
> > '"' quotes, extra backslashes are needed. That is not necessary when it
> > is enclosed in curly braces.
> >
> > For example, "ld.w" will be matched in:
> >
> > .ascii "h\227\022\212ld@w\251jr\254'\320\255vwj\252\026\016\364"
> >
> > If you write {\mld\.w\M} instead, you avoid this problem.
> OK. So that naturally leads to the question, why aren't others seeing
> this, both in the RISC-V world and more generally. I'm not aware of any
> case where I've run the testsuite and tripped over this issue, nor am I
> aware of anyone else tripping over it.
I can answer the more generally part. Most other testcases if not all
scan-assembler tries to add spaces that allow not to catch things out
of place. Or even file/directory names.
The documentation at
https://gcc.gnu.org/onlinedocs/gccint/Final-Actions.html (and/or
https://gcc.gnu.org/wiki/HowToPrepareATestcase) definitely could be
expanded to make a mention of these gotchas really.
Thanks,
Andrew
>
> Jeff
next prev parent reply other threads:[~2023-09-27 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 9:26 Joern Rennecke
2023-09-27 17:22 ` Jeff Law
2023-09-27 18:22 ` Joern Rennecke
2023-09-27 20:14 ` Jeff Law
2023-09-27 22:12 ` Andrew Pinski [this message]
2023-09-27 23:21 ` Vineet Gupta
2023-09-29 13:54 ` Jeff Law
2023-09-30 21:12 ` Joern Rennecke
2023-10-11 4:48 ` Joern Rennecke
2023-10-11 7:12 ` Joern Rennecke
2023-11-08 15:14 ` Joern Rennecke
2023-11-08 16:00 ` RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns) Joern Rennecke
2023-11-10 6:02 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1=NOiz4hYp1khs36a-x=zWqw1t2FYnX3pCDh7_7JBsDgg@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=joern.rennecke@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).