From: Andrew Pinski <pinskia@gmail.com>
To: Ajit Agarwal <aagarwa1@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, bergner@linux.ibm.com, ",
Segher Boessenkool" <segher@kernel.crashing.org>
Subject: Re: [PATCH] rs6000: fmr gets used instead of faster xxlor [PR93571]
Date: Fri, 17 Feb 2023 09:09:38 -0800 [thread overview]
Message-ID: <CA+=Sn1kw9aD2=7oN+C+r5TNgBZi9nshJQ+BHbe+DVnUTD=9wJw@mail.gmail.com> (raw)
In-Reply-To: <16fa34b8-ad8a-20f2-b285-3b3f5bf5d5b2@linux.ibm.com>
On Fri, Feb 17, 2023 at 8:59 AM Ajit Agarwal via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> Hello All:
>
> This patch replaces fmr instruction (6 cycles) with xxlor instruction ( 2 cycles)
> Bootstrapped and regtested on powerpc64-linux-gnu.
I don't think this can be unconditionally replaced.
xxlor only exists in newer Power ISA.
Thanks,
Andrew Pinski
>
> copyright assignment form is still in the process of being sent.
>
> Thanks & Regards
> Ajit
>
> rs6000: fmr gets used instead of faster xxlor [PR93571]
>
> This patch replaces 6 cycles fmr instruction with xxlor
> 2 cycles.
>
> 2023-02-17 Ajit Kumar Agarwal <aagarwa1@linux.ibm.com>
>
> gcc/ChangeLog:
>
> * config/rs6000/rs6000.md (*movdf_hardfloat64): Replace fmr with xxlor instruction.
> ---
> gcc/config/rs6000/rs6000.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
> index 4a7812fa592..dfd6c73ffcb 100644
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -8436,7 +8436,7 @@
> "@
> stfd%U0%X0 %1,%0
> lfd%U1%X1 %0,%1
> - fmr %0,%1
> + xxlor %0,%1,%1
> lxsd %0,%1
> stxsd %1,%0
> lxsdx %x0,%y1
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2023-02-17 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 16:58 Ajit Agarwal
2023-02-17 17:09 ` Andrew Pinski [this message]
2023-02-17 17:23 ` Segher Boessenkool
2023-02-21 8:48 ` Ajit Agarwal
2023-02-21 11:04 ` Segher Boessenkool
2023-02-21 12:30 ` Ajit Agarwal
2023-02-21 14:09 ` Segher Boessenkool
2023-02-22 10:28 ` Ajit Agarwal
2023-02-24 8:11 ` Ajit Agarwal
2023-02-24 15:11 ` Segher Boessenkool
2023-02-25 7:42 ` Ajit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1kw9aD2=7oN+C+r5TNgBZi9nshJQ+BHbe+DVnUTD=9wJw@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=aagarwa1@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).