Re: [pushed] [PR103541] RA: Implement reuse of equivalent memory for caller saves optimization

[Andrew Pinski <pinskia@gmail.com>]

On Tue, Feb 7, 2023 at 6:08 AM Vladimir Makarov via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The following patch solves
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103541
>
> The patch was successfully bootstrapped and tested on x86-64, aarch64,
> and ppc64le.

What languages did you test? Because I think I am getting a bootstrap
failure while building libgo in 32bit x86 due to this patch.

libtool: compile:
/home/apinski/src/upstream-gcc-git/gcc/objdir/./gcc/gccgo
-B/home/apinski/src/upstream-gcc-git/gcc/objdir/./gcc/
-B/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/bin/
-B/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/lib/ -isystem
/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/include -isystem
/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/sys-include
-minline-all-stringops -O2 -g -m32 -I . -c -fgo-pkgpath=reflect
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/deepequal.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/eqtype.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/makefunc.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/makefunc_ffi.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/swapper.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/value.go
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/visiblefields.go
 -fPIC -o .libs/reflect.o
during RTL pass: reload
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go: In
function ‘reflect.rtype.Method’:
/home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go:604:1:
internal compiler error: in get_equiv, at lra-constraints.cc:534
  604 | func (t *rtype) Method(i int) (m Method) {
      | ^
0x7f9cfb get_equiv
        /home/apinski/src/upstream-gcc-git/gcc/gcc/lra-constraints.cc:534
0xde58d4 lra_constraints(bool)
        /home/apinski/src/upstream-gcc-git/gcc/gcc/lra-constraints.cc:5052
0xdd2532 lra(_IO_FILE*)
        /home/apinski/src/upstream-gcc-git/gcc/gcc/lra.cc:2375
0xd8a101 do_reload
        /home/apinski/src/upstream-gcc-git/gcc/gcc/ira.cc:5955
0xd8a101 execute
        /home/apinski/src/upstream-gcc-git/gcc/gcc/ira.cc:6141
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
Makefile:3043: recipe for target 'reflect.lo' failed
make[7]: *** [reflect.lo] Error 1


Thanks,
Andrew Pinski