public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: juzhe.zhong@rivai.ai
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com
Subject: Re: [PATCH] RISC-V: Support (set (mem) (const_poly_int))
Date: Sun, 23 Oct 2022 19:14:10 -0700	[thread overview]
Message-ID: <CA+=Sn1nz=v5mZ9FZS5f8nmFBqgjLmPeZEfX7tWjT1DpS7MxqiQ@mail.gmail.com> (raw)
In-Reply-To: <20221024020312.26851-1-juzhe.zhong@rivai.ai>

On Sun, Oct 23, 2022 at 7:04 PM <juzhe.zhong@rivai.ai> wrote:
>
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> gcc/ChangeLog:
>
>         * config/riscv/riscv.cc (riscv_legitimize_move): Support (set (mem) (const_poly_int)).
>
> ---
>  gcc/config/riscv/riscv.cc | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 90a39047dd7..f7694ba043c 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -1958,6 +1958,20 @@ riscv_legitimize_move (machine_mode mode, rtx dest, rtx src)
>  {
>    if (CONST_POLY_INT_P (src))
>      {
> +      /*
> +       Handle:
> +         (insn 183 182 184 6 (set (mem:QI (plus:DI (reg/f:DI 156)
> +                 (const_int 96 [0x60])) [0  S1 A8])
> +         (const_poly_int:QI [8, 8]))
> +       "../../../../riscv-gcc/libgcc/unwind-dw2.c":1579:3 -1 (nil))
> +      */
> +      if (MEM_P (dest))
> +       {
> +         rtx tmp = gen_reg_rtx (mode);
> +         emit_move_insn (tmp, src);
> +         emit_move_insn (dest, tmp);

Couldn't you just use force_reg here instead of the above?
Something like:
emit_move_insn (dest, force_reg (mode, src));

Thanks,
Andrew Pinski

> +         return true;
> +       }
>        poly_int64 value = rtx_to_poly_int64 (src);
>        if (!value.is_constant () && !TARGET_VECTOR)
>         {
> --
> 2.36.1
>

  reply	other threads:[~2022-10-24  2:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  2:03 juzhe.zhong
2022-10-24  2:14 ` Andrew Pinski [this message]
2022-10-24  2:22   ` juzhe.zhong
2022-10-24  2:27 juzhe.zhong
2022-10-24  2:50 ` Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1nz=v5mZ9FZS5f8nmFBqgjLmPeZEfX7tWjT1DpS7MxqiQ@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).