From: Kito Cheng <kito.cheng@gmail.com>
To: "Monk Chiang" <monk.chiang@sifive.com>, 钟居哲 <juzhe.zhong@rivai.ai>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Remove unnecessary register class.
Date: Fri, 3 Feb 2023 15:15:50 +0800 [thread overview]
Message-ID: <CA+yXCZB4wv24cskXGcnwiGZ5wRjVPK9opC-wifWsyeUMjWTjqg@mail.gmail.com> (raw)
In-Reply-To: <20230203045851.43100-1-monk.chiang@sifive.com>
committed, also updated mask for ALL_REGS, thanks.
On Fri, Feb 3, 2023 at 12:59 PM Monk Chiang <monk.chiang@sifive.com> wrote:
>
> Avoid VL_REGS, VTYPE_REGS join register allocation.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.h: Remove VL_REGS, VTYPE_REGS class.
> * config/riscv/riscv.cc: Ditto.
> ---
> gcc/config/riscv/riscv.cc | 8 +-------
> gcc/config/riscv/riscv.h | 6 ------
> 2 files changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 209d9a53e7b..3b7804b7501 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -293,7 +293,7 @@ const enum reg_class riscv_regno_to_class[FIRST_PSEUDO_REGISTER] = {
> FP_REGS, FP_REGS, FP_REGS, FP_REGS,
> FP_REGS, FP_REGS, FP_REGS, FP_REGS,
> FP_REGS, FP_REGS, FP_REGS, FP_REGS,
> - FRAME_REGS, FRAME_REGS, VL_REGS, VTYPE_REGS,
> + FRAME_REGS, FRAME_REGS, NO_REGS, NO_REGS,
> NO_REGS, NO_REGS, NO_REGS, NO_REGS,
> NO_REGS, NO_REGS, NO_REGS, NO_REGS,
> NO_REGS, NO_REGS, NO_REGS, NO_REGS,
> @@ -5831,12 +5831,6 @@ riscv_class_max_nregs (reg_class_t rclass, machine_mode mode)
> if (reg_class_subset_p (rclass, V_REGS))
> return riscv_hard_regno_nregs (V_REG_FIRST, mode);
>
> - if (reg_class_subset_p (rclass, VL_REGS))
> - return 1;
> -
> - if (reg_class_subset_p (rclass, VTYPE_REGS))
> - return 1;
> -
> return 0;
> }
>
> diff --git a/gcc/config/riscv/riscv.h b/gcc/config/riscv/riscv.h
> index 0ab739bd6eb..02e1224c3cd 100644
> --- a/gcc/config/riscv/riscv.h
> +++ b/gcc/config/riscv/riscv.h
> @@ -462,8 +462,6 @@ enum reg_class
> GR_REGS, /* integer registers */
> FP_REGS, /* floating-point registers */
> FRAME_REGS, /* arg pointer and frame pointer */
> - VL_REGS, /* vl register */
> - VTYPE_REGS, /* vtype register */
> VM_REGS, /* v0.t registers */
> VD_REGS, /* vector registers except v0.t */
> V_REGS, /* vector registers */
> @@ -487,8 +485,6 @@ enum reg_class
> "GR_REGS", \
> "FP_REGS", \
> "FRAME_REGS", \
> - "VL_REGS", \
> - "VTYPE_REGS", \
> "VM_REGS", \
> "VD_REGS", \
> "V_REGS", \
> @@ -514,8 +510,6 @@ enum reg_class
> { 0xffffffff, 0x00000000, 0x00000000, 0x00000000 }, /* GR_REGS */ \
> { 0x00000000, 0xffffffff, 0x00000000, 0x00000000 }, /* FP_REGS */ \
> { 0x00000000, 0x00000000, 0x00000003, 0x00000000 }, /* FRAME_REGS */ \
> - { 0x00000000, 0x00000000, 0x00000004, 0x00000000 }, /* VL_REGS */ \
> - { 0x00000000, 0x00000000, 0x00000008, 0x00000000 }, /* VTYPE_REGS */ \
> { 0x00000000, 0x00000000, 0x00000000, 0x00000001 }, /* V0_REGS */ \
> { 0x00000000, 0x00000000, 0x00000000, 0xfffffffe }, /* VNoV0_REGS */ \
> { 0x00000000, 0x00000000, 0x00000000, 0xffffffff }, /* V_REGS */ \
> --
> 2.37.2
>
prev parent reply other threads:[~2023-02-03 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 4:58 Monk Chiang
2023-02-03 7:15 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZB4wv24cskXGcnwiGZ5wRjVPK9opC-wifWsyeUMjWTjqg@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=monk.chiang@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).