From: Kito Cheng <kito.cheng@gmail.com>
To: juzhe.zhong@rivai.ai
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Fix a mistake in previous patch.
Date: Wed, 26 Oct 2022 17:02:29 +0800 [thread overview]
Message-ID: <CA+yXCZB5CZrT9OgSgQM3MKbYq4x3CgpnCP-y8dZc+-bHvmEJkg@mail.gmail.com> (raw)
In-Reply-To: <20221025135323.98303-1-juzhe.zhong@rivai.ai>
Committed with title tweak, thanks
On Tue, Oct 25, 2022 at 9:53 PM <juzhe.zhong@rivai.ai> wrote:
>
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> I noticed that I have made a mistake in previous patch:
> https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/
>
> The previous statement before this patch:
> bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0;
>
> However, I changed it in the previous patch:
> bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
> This is incorrect.
>
> Now, I correct this statement in this patch.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement.
>
> ---
> gcc/config/riscv/riscv.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 08354a19c05..50ef38438a2 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -5028,8 +5028,8 @@ riscv_expand_epilogue (int style)
> rtx insn;
>
> /* We need to add memory barrier to prevent read from deallocated stack. */
> - bool need_barrier_p
> - = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
> + bool need_barrier_p = known_ne (get_frame_size ()
> + + cfun->machine->frame.arg_pointer_offset, 0);
>
> if (cfun->machine->naked_p)
> {
> --
> 2.36.1
>
prev parent reply other threads:[~2022-10-26 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 13:53 juzhe.zhong
2022-10-26 9:02 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZB5CZrT9OgSgQM3MKbYq4x3CgpnCP-y8dZc+-bHvmEJkg@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).