From: Kito Cheng <kito.cheng@gmail.com>
To: Jeff Law <jlaw@ventanamicro.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [committed][RISC-V] Fix recent rvv/base/spill testcase failures
Date: Wed, 23 Nov 2022 11:39:39 +0800 [thread overview]
Message-ID: <CA+yXCZBS=KPGv1Q3xZM3Wm4fTGgXf=o4OF_03j=Q7M_JXEoP1w@mail.gmail.com> (raw)
In-Reply-To: <293c6900-a6b8-9bcb-9752-5f41554e80c5@ventanamicro.com>
LGTM, thanks :)
On Wed, Nov 23, 2022 at 7:21 AM Jeff Law <jlaw@ventanamicro.com> wrote:
>
> As Jaiwei noted, many (all?) of the rvv/base/spill tests started failing
> after the introduction of shrink-wrapping.
>
>
> The core issue is we're expecting the frame to have a constant size, but
> it doesn't. So when using the to_constant method we abort.
>
>
> The safest thing to do is to set no shrink-wrapping components when the
> frame size is not fixed. We might be able to do better later -- iff we
> know the offset to the GPRs/FPRs is fixed and fits into the appropriate
> number of bits.
>
>
> Bootstrapped and regression tested (C-only) on riscv64-linux-gnu. As
> expected, it fixes a bucketload of failures in rvv/base/spill-*.c.
>
>
> Installed on the trunk,
>
> Jeff
prev parent reply other threads:[~2022-11-23 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 23:20 Jeff Law
2022-11-23 3:39 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZBS=KPGv1Q3xZM3Wm4fTGgXf=o4OF_03j=Q7M_JXEoP1w@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).