From: Kito Cheng <kito.cheng@gmail.com>
To: juzhe.zhong@rivai.ai
Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Fix incorrect attributes of vsetvl instructions pattern
Date: Fri, 27 Jan 2023 17:35:52 +0800 [thread overview]
Message-ID: <CA+yXCZBWZ+XUo6H4Q78+b4rJWmeRqTEr_SUOier3Q5ouMmt1ZQ@mail.gmail.com> (raw)
In-Reply-To: <20230118024415.64340-1-juzhe.zhong@rivai.ai>
[-- Attachment #1: Type: text/plain, Size: 3011 bytes --]
committed, thanks!
On Wed, Jan 18, 2023 at 10:44 AM <juzhe.zhong@rivai.ai> wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> gcc/ChangeLog:
>
> * config/riscv/vector.md: Fix incorrect attributes.
>
> ---
> gcc/config/riscv/vector.md | 27 ++++++++++++---------------
> 1 file changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md
> index 4e93b7fead5..37cf4d6bcbf 100644
> --- a/gcc/config/riscv/vector.md
> +++ b/gcc/config/riscv/vector.md
> @@ -95,13 +95,7 @@
> (const_int 32)
> (eq_attr "mode" "VNx1DI,VNx2DI,VNx4DI,VNx8DI,\
> VNx1DF,VNx2DF,VNx4DF,VNx8DF")
> - (const_int 64)
> -
> - (eq_attr "type" "vsetvl")
> - (if_then_else (eq_attr "INSN_CODE (curr_insn) == CODE_FOR_vsetvldi
> - || INSN_CODE (curr_insn) ==
> CODE_FOR_vsetvlsi")
> - (symbol_ref "INTVAL (operands[2])")
> - (const_int INVALID_ATTRIBUTE))]
> + (const_int 64)]
> (const_int INVALID_ATTRIBUTE)))
>
> ;; Ditto to LMUL.
> @@ -149,12 +143,7 @@
> (eq_attr "mode" "VNx4DI,VNx4DF")
> (symbol_ref "riscv_vector::get_vlmul(E_VNx4DImode)")
> (eq_attr "mode" "VNx8DI,VNx8DF")
> - (symbol_ref "riscv_vector::get_vlmul(E_VNx8DImode)")
> - (eq_attr "type" "vsetvl")
> - (if_then_else (eq_attr "INSN_CODE (curr_insn) == CODE_FOR_vsetvldi
> - || INSN_CODE (curr_insn) ==
> CODE_FOR_vsetvlsi")
> - (symbol_ref "INTVAL (operands[3])")
> - (const_int INVALID_ATTRIBUTE))]
> + (symbol_ref "riscv_vector::get_vlmul(E_VNx8DImode)")]
> (const_int INVALID_ATTRIBUTE)))
>
> ;; It is valid for instruction that require sew/lmul ratio.
> @@ -531,7 +520,11 @@
> "TARGET_VECTOR"
> "vset%i1vli\t%0,%1,e%2,%m3,t%p4,m%p5"
> [(set_attr "type" "vsetvl")
> - (set_attr "mode" "<MODE>")])
> + (set_attr "mode" "<MODE>")
> + (set (attr "sew") (symbol_ref "INTVAL (operands[2])"))
> + (set (attr "vlmul") (symbol_ref "INTVAL (operands[3])"))
> + (set (attr "ta") (symbol_ref "INTVAL (operands[4])"))
> + (set (attr "ma") (symbol_ref "INTVAL (operands[5])"))])
>
> ;; vsetvl zero,zero,vtype instruction.
> ;; This pattern has no side effects and does not set X0 register.
> @@ -563,7 +556,11 @@
> "TARGET_VECTOR"
> "vset%i0vli\tzero,%0,e%1,%m2,t%p3,m%p4"
> [(set_attr "type" "vsetvl")
> - (set_attr "mode" "<MODE>")])
> + (set_attr "mode" "<MODE>")
> + (set (attr "sew") (symbol_ref "INTVAL (operands[1])"))
> + (set (attr "vlmul") (symbol_ref "INTVAL (operands[2])"))
> + (set (attr "ta") (symbol_ref "INTVAL (operands[3])"))
> + (set (attr "ma") (symbol_ref "INTVAL (operands[4])"))])
>
> ;; It's emit by vsetvl/vsetvlmax intrinsics with no side effects.
> ;; Since we have many optmization passes from "expand" to
> "reload_completed",
> --
> 2.36.3
>
>
prev parent reply other threads:[~2023-01-27 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 2:44 juzhe.zhong
2023-01-27 9:35 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZBWZ+XUo6H4Q78+b4rJWmeRqTEr_SUOier3Q5ouMmt1ZQ@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).