From: Kito Cheng <kito.cheng@gmail.com>
To: juzhe.zhong@rivai.ai
Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Fix wrong in_group flag in validate_change call function
Date: Fri, 27 Jan 2023 03:13:12 +0800 [thread overview]
Message-ID: <CA+yXCZBuutn=XgDYkZuChY9oaz+4Zi+ohJ9kib5+b5kweDZdtQ@mail.gmail.com> (raw)
In-Reply-To: <20230103071159.147469-1-juzhe.zhong@rivai.ai>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
committed, thanks.
On Tue, Jan 3, 2023 at 3:12 PM <juzhe.zhong@rivai.ai> wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> Since we only change insn which is not in group. The flag currently is not
> correct.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc (change_insn): Adjust in_group in
> validate_change.
>
> ---
> gcc/config/riscv/riscv-vsetvl.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv-vsetvl.cc
> b/gcc/config/riscv/riscv-vsetvl.cc
> index 1afe76304fb..ad0457ed89d 100644
> --- a/gcc/config/riscv/riscv-vsetvl.cc
> +++ b/gcc/config/riscv/riscv-vsetvl.cc
> @@ -787,7 +787,7 @@ change_insn (rtx_insn *rinsn, rtx new_pat)
> print_rtl_single (dump_file, PATTERN (rinsn));
> }
>
> - validate_change (rinsn, &PATTERN (rinsn), new_pat, true);
> + validate_change (rinsn, &PATTERN (rinsn), new_pat, false);
>
> if (dump_file)
> {
> --
> 2.36.3
>
>
prev parent reply other threads:[~2023-01-26 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 7:11 juzhe.zhong
2023-01-26 19:13 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZBuutn=XgDYkZuChY9oaz+4Zi+ohJ9kib5+b5kweDZdtQ@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).